Open
Conversation
Set up the PVs so they are broadcasted from a json. Will need to add setters
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 84.30% 86.00% +1.69%
==========================================
Files 3 4 +1
Lines 172 250 +78
==========================================
+ Hits 145 215 +70
- Misses 27 35 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DominicOram
requested changes
Dec 15, 2022
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
Generally looks good, I like the fake pin shapes! Could you address the minor comments in code and remove the empty MO-IOC.db file?
DominicOram
requested changes
Dec 20, 2022
Contributor
DominicOram
left a comment
There was a problem hiding this comment.
On starting the IOCs I get a bunch of errors about asyn links and I/O Intr not valid. Can you set them to soft records or remove them to make sure it doesn't error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance criteria:
Fixes #26