fix: Add null fallback for firewall rules response#367
Open
zigzagdev wants to merge 1 commit into
Open
Conversation
zigzagdev
force-pushed
the
add-fallback-method
branch
from
8fdd176 to
0f1d255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have done
Add null coalescing fallback (
?? []) to above method in Database.php to prevent errors when the API response returns null for rules.getFirewallRulesgetBackupsgetAllReplicasgetAllUsersgetAllDatabasesgetAllConnectionPoolsNotes
Because there are no existing tests cover the Database API, tests were not included in this PR.
Happy to add PHPUnit tests if needed!