Fix Tailscale validator resilience across CLI/path edge cases#466
Open
Crabbotix wants to merge 1 commit intoDimillian:mainfrom
Open
Fix Tailscale validator resilience across CLI/path edge cases#466Crabbotix wants to merge 1 commit intoDimillian:mainfrom
Crabbotix wants to merge 1 commit intoDimillian:mainfrom
Conversation
Author
|
Reviewer quick context (What / Why / How): What:
Why:
How:
Happy to split/trim further if maintainers prefer a narrower patch shape. |
Author
|
Cross-OS note (important): this app is multi-platform and this patch was reviewed with macOS/Linux/Windows paths in mind. What is cross-platform-safe in this PR:
Known existing parity gap (not introduced by this PR):
CI coverage note:
If maintainers want, I can follow with a focused Windows parity PR for the forced-stop fallback path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
We observed false validator failures even when Tailscale was installed and connected.
In local validation we confirmed a key environment contributor: the Tailscale GUI was installed and running, but the CLI was not discoverable via a normal
tailscalecommand path. That can cause status probing to fail despite healthy Tailnet connectivity.This PR keeps behavior robust even when environments differ:
How
Backend hardening
src-tauri/src/tailscale/mod.rstailscale_output(...)with macOS fallback fromlaunchctl asuserto direct execution.TailscaleStatusresponses (installed: true,running: false, informativemessage).src-tauri/src/tailscale/core.rsTests
Validation performed
cd src-tauri && cargo test tailscale::core::tests::status_from_json_cd src-tauri && cargo test tailscale::tests::truncates_preview_without_utf8_boundary_panicscd src-tauri && cargo checkAdditionally, on local machine after fixing CLI exposure,
tailscale versionandtailscale status --jsonboth returned healthy output withBackendState: Running.