Skip to content

Feature/capture screenshot#365

Merged
nicoburns merged 6 commits intoDioxusLabs:mainfrom
mogambro:feature/capture_screenshot
Mar 6, 2026
Merged

Feature/capture screenshot#365
nicoburns merged 6 commits intoDioxusLabs:mainfrom
mogambro:feature/capture_screenshot

Conversation

@mogambro
Copy link
Copy Markdown
Contributor

@mogambro mogambro commented Mar 3, 2026

Screenshot from 2026-03-03 20-43-01 Screenshot from 2026-03-03 20-43-12

Comment thread apps/browser/src/main.rs Outdated
@mogambro mogambro force-pushed the feature/capture_screenshot branch from 0b99a74 to 3bae370 Compare March 3, 2026 19:45
Comment thread apps/browser/Cargo.toml
Comment thread apps/browser/src/main.rs Outdated
Comment thread apps/browser/src/main.rs Outdated
@mogambro mogambro closed this Mar 6, 2026
@mogambro mogambro force-pushed the feature/capture_screenshot branch from 3bae370 to 826436d Compare March 6, 2026 09:22
@mogambro
Copy link
Copy Markdown
Contributor Author

mogambro commented Mar 6, 2026

Huch, why did I close this by merely rebasing to main? oO

Hm, something really went wrong here...

mogambro added 2 commits March 6, 2026 10:31
This allows to, well, view the source code of the current document.

Trade-Off: We store the entire source as a Signal<String> ... an
alternative would be to refetch it.
@mogambro mogambro reopened this Mar 6, 2026
@mogambro mogambro requested a review from nicoburns March 6, 2026 10:22
Signed-off-by: Nico Burns <nico@nicoburns.com>
Copy link
Copy Markdown
Member

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the sync file dialog was panicking for me on macOS. So I've changed this to use the async file dialog. Otherwise this looks good :)

Signed-off-by: Nico Burns <nico@nicoburns.com>
@mogambro
Copy link
Copy Markdown
Contributor Author

mogambro commented Mar 6, 2026

Pleasure doing business with you :) Have a wonderful day!

@nicoburns nicoburns merged commit 3640a74 into DioxusLabs:main Mar 6, 2026
14 checks passed
@mogambro mogambro deleted the feature/capture_screenshot branch March 6, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants