Fix api/v1/projects?languages=X query which failed with DB error#1581
Open
bpfoley wants to merge 1 commit into
Open
Fix api/v1/projects?languages=X query which failed with DB error#1581bpfoley wants to merge 1 commit into
bpfoley wants to merge 1 commit into
Conversation
Collaborator
Author
|
Reproducer to find a project with English as the primary language. Fails without this patch |
cpeel
requested changes
May 14, 2026
Comment on lines
-74
to
+79
| if (in_array($field, ["author", "title", "languages", "clearance"])) { | ||
| // Languages occur as one language or two and are stored as | ||
| // "Lang1" or "Lang1 with Lang2" in projects.language. | ||
| // See Project.inc:encode_languages | ||
| if ($field == "languages") { | ||
| $likes_str = surround_and_join($values, "language LIKE '%", "%'", ' OR '); | ||
| $where .= " AND ($likes_str)"; | ||
| } elseif (in_array($field, ["author", "title", "clearance"])) { |
Member
There was a problem hiding this comment.
It took me way to long to spot the difference here, this might be more straightforward:
// The API exposes "languages" but the table column is "language" and
// are stored as "Lang1" or "Lang1 with Lang2".
// See Project.inc:encode_languages
if ($field == "languages") {
$column_name = "language";
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.