-
Notifications
You must be signed in to change notification settings - Fork 3
Switch project to using uv rather than poetry #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uses the uv sync --resolution switch to test against the lowest direct dependencies
For python 3.10 and 3.11:The version lowest-direct fails because gsw seems to be compiled for numpy 1.x, while the projects uses numpy 2.x (with a version For python 3.12 and 3.13:
This error comes from pint |
|
What should we do? If we follow SPEC0, we should drop numpy<2 support, and python 3.10 support. Recent versions of xarray already have a python >=3.11 requirement, but hasn't yet dropped numpy 1. GSW tests against numpy2 starting with v3.6.18. When I did my initial testing, indeed found that the "lowest" strategy was a bit of a mess. |
|
I agree the lowest is a mess ^^, but that’s why it should be tested I guess I believe that we can drop 3.10 support, and require gsw>=3.6.18. As our new version does not bring any extra feature, this will not block any user that still uses python 3.10 and old gsw version |
|
For the pint error, version 0.24.1 seems to be compatible with numpy 2 and 1 |
|
What I propose is:
|
|
Sounds good, feel free to push updates to this pr. |
|
We need pint>0.24.4 |
|
I added ci for python 3.14 as it is gonna be released soon, so it is done :) |
|
@DocOtak can you review and merge if you’re happy with the modifications? |
Converts project to using uv for every part of its lifecycle.
Some notable changes:
Closes #78