fix: Remove .sql for mongo backup file name#2753
Merged
Siumauricio merged 6 commits intoDokploy:canaryfrom Mar 24, 2026
Merged
Conversation
Contributor
Author
|
Retested functionality - n+ is able to catch .bson.gz alongside sql.gz and remove the oldest one. |
|
Hi @MichalMaciejKowal even if my dokploy is up to date and the mongo image freshly pulled, I still have the mongo backup using .sql.gz and with a .sql file inside :( Is this fix already deployed ? |
Contributor
Author
It needs to be reviewed, merged and deployed |
- Changed the backup file name extension to use '.bson' for MongoDB and '.sql' for other database types, ensuring correct file formats for backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Please describe in a short paragraph what this PR is about.
The file extension name for MongoDB contained .sql in name which may have been confusing.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #2731
Screenshots (if applicable)