Skip to content

fix: Remove .sql for mongo backup file name#2753

Merged
Siumauricio merged 6 commits intoDokploy:canaryfrom
MichalMaciejKowal:2731-wrong-extension-for-mongo-backup-file
Mar 24, 2026
Merged

fix: Remove .sql for mongo backup file name#2753
Siumauricio merged 6 commits intoDokploy:canaryfrom
MichalMaciejKowal:2731-wrong-extension-for-mongo-backup-file

Conversation

@MichalMaciejKowal
Copy link
Copy Markdown
Contributor

@MichalMaciejKowal MichalMaciejKowal commented Oct 3, 2025

What is this PR about?

Please describe in a short paragraph what this PR is about.

The file extension name for MongoDB contained .sql in name which may have been confusing.

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

closes #2731

Screenshots (if applicable)

dokploy_correct_extension

@MichalMaciejKowal MichalMaciejKowal changed the title Remove .sql for mongo backup file name fix: Remove .sql for mongo backup file name Oct 3, 2025
@MichalMaciejKowal MichalMaciejKowal marked this pull request as ready for review October 5, 2025 01:23
@MichalMaciejKowal
Copy link
Copy Markdown
Contributor Author

Retested functionality - n+ is able to catch .bson.gz alongside sql.gz and remove the oldest one.

@AK-digital
Copy link
Copy Markdown

Hi @MichalMaciejKowal even if my dokploy is up to date and the mongo image freshly pulled, I still have the mongo backup using .sql.gz and with a .sql file inside :(

Is this fix already deployed ?

@MichalMaciejKowal
Copy link
Copy Markdown
Contributor Author

Hi @MichalMaciejKowal even if my dokploy is up to date and the mongo image freshly pulled, I still have the mongo backup using .sql.gz and with a .sql file inside :(

Is this fix already deployed ?

It needs to be reviewed, merged and deployed

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 24, 2026
- Changed the backup file name extension to use '.bson' for MongoDB and '.sql' for other database types, ensuring correct file formats for backups.
@Siumauricio Siumauricio merged commit ddfcd1a into Dokploy:canary Mar 24, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backup issue on mongo db

3 participants