feat(compose): add configurable MTU for isolated networks#4071
Open
Hobby-Student wants to merge 1 commit intoDokploy:canaryfrom
Open
feat(compose): add configurable MTU for isolated networks#4071Hobby-Student wants to merge 1 commit intoDokploy:canaryfrom
Hobby-Student wants to merge 1 commit intoDokploy:canaryfrom
Conversation
|
Related Documentation 2 document(s) may need updating based on files changed in this PR: Dokploy's Space AGENTS
|
apps/dokploy/components/dashboard/compose/advanced/add-isolation.tsx
Outdated
Show resolved
Hide resolved
c58e4f0 to
fad2093
Compare
fad2093 to
26a72eb
Compare
Author
|
I updated the PR accordingly to the suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
It's about setting MTU on docker compose (not swarm).
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
#3446
Screenshots (if applicable)
Greptile Summary
This PR adds a configurable MTU option for isolated Docker Compose networks, allowing users to set a custom MTU (e.g., 1350 for VPN/overlay environments) when isolated deployment is enabled. The database migration, schema, UI field, and shell command generation all follow established patterns in the codebase.
Key findings:
.env.productionfile — an empty file was committed that is unrelated to this feature and should be removed before merge.<FormMessage />in the MTU input field — Zod validation errors (out-of-range values) will be silently swallowed and the form will appear to do nothing, with no feedback to the user..int()— MTU values are always whole numbers; accepting floats allows values like1499.5that PostgreSQL silently truncates to an integer.composeType !== "stack", since Docker overlay/swarm networks do not support the--opt com.docker.network.driver.mtuflag.Confidence Score: 3/5
.env.productioncommit and missing form validation feedback need to be addressed first..env.productionfile is a clear mistake that must be reverted, and the missingFormMessagemeans users get no feedback when they enter an invalid MTU value, which is a noticeable UX regression on a newly added form field..env.production(should not be committed) andapps/dokploy/components/dashboard/compose/advanced/add-isolation.tsx(missingFormMessage, missing.int()validation).Comments Outside Diff (1)
.env.production, line 1 (link)An empty
.env.productionfile has been added to the repository. This file appears to be accidentally included in this PR — it has no relation to the MTU feature and should not be committed.Production environment files typically contain sensitive credentials and are expected to be in
.gitignore. Committing an empty one can mislead maintainers or cause issues if the real populated file is later committed on top of it.Reviews (1): Last reviewed commit: "feat(compose): add configurable MTU for ..." | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!