Skip to content

Add inb.so subdomain configuration file#695

Closed
AudEarn wants to merge 8 commits intoDomain-Connect:masterfrom
AudEarn:master
Closed

Add inb.so subdomain configuration file#695
AudEarn wants to merge 8 commits intoDomain-Connect:masterfrom
AudEarn:master

Conversation

@AudEarn
Copy link
Copy Markdown

@AudEarn AudEarn commented Dec 31, 2025

Add INB.so subdomain routing template

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

Add INB.so subdomain routing template
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 31, 2025

Linter OK

inb.so.subdomain.json

Level Code Note
info DCTL1029 template does not have syncPubKeyDomain
info DCTL1024 use of %host% variable name is problematic

@kerolasa kerolasa self-requested a review January 5, 2026 09:58
Copy link
Copy Markdown
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread inb.so.subdomain.json
"records": [
{
"type": "CNAME",
"host": "%host%",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False usage of %host% variable to create subdomains

Suggested change
"host": "%host%",
"host": "@",

Comment thread inb.so.subdomain.json
"logoUrl": "https://inb1.lovable.app/inb-logo.png",
"description": "Creates a subdomain for INB.so order routing",
"variableDescription": "The subdomain prefix for your order page",
"warnPhishing": false,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding signing. Template will be rejected by some providers like Cloudflare without.

@pawel-kow pawel-kow added the PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. label Jan 19, 2026
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions Bot added the Stale label Feb 19, 2026
@pawel-kow
Copy link
Copy Markdown
Member

Please follow the README.md and fill in description as per Template.

@github-actions github-actions Bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. Test links missing No test links from Online Editor provided labels Mar 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

Labels to apply: Checklist of common problems not complete, PR description incomplete, Test links missing

PR description check FAILED:
  FAIL  'Type of change': no checkboxes are ticked
  FAIL  'How Has This Been Tested?': 5/5 checkboxes are not ticked
  FAIL  'Checklist of common problems' section not found
  FAIL  'Online Editor test results' section not found
  FAIL  Template coverage: inb.so.subdomain.json: no editor test link found (expected template id 'inb.so.subdomain')

@github-actions github-actions Bot removed the Stale label Mar 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions Bot added the Stale label Apr 5, 2026
@github-actions
Copy link
Copy Markdown

Closing stale PR after 15 days

@github-actions github-actions Bot closed this Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Stale Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants