Skip to content

domain connect template for uspeedo.com#701

Open
kiritoaurora wants to merge 7 commits intoDomain-Connect:masterfrom
kiritoaurora:master
Open

domain connect template for uspeedo.com#701
kiritoaurora wants to merge 7 commits intoDomain-Connect:masterfrom
kiritoaurora:master

Conversation

@kiritoaurora
Copy link

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Example variable values

<-- to make review process easier please provide example set of variable values for this template -->

<-- Example: -->

var1: aaa
var2: foo.com

<-- Or provide the whole testData object from the Online Editor after testing and using "Add as test" button -->

"testData": {
    "testset": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Linter OK

uspeedo.com.email.json

Level Code Note
info DCTL1032 mix of empty and defined record groupId values

@kerolasa
Copy link
Collaborator

kerolasa commented Jan 7, 2026

Could you reconsider use of %host% variable?

https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1024

@kiritoaurora
Copy link
Author

Could you reconsider use of %host% variable?你能重新考虑使用 %host% 变量吗?

https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1024

@kerolasa I have changed the variable %host% to %subdomain%. Is that okay?

@kerolasa kerolasa self-requested a review January 8, 2026 12:21
Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

{
"type": "CNAME",
"groupId": "tracking",
"host": "%track_host%",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this host under %subdomain%?
If it is the whole template could have used @ instead of %subdomain% and standard host parameter, which has quite benefits - template can be applied several times to the same domain and different subdomains if needed.
Otherwise multiInstance setting might be of help.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Feb 19, 2026
@pawel-kow
Copy link
Member

Please follow the README.md and fill in description as per Template.

@github-actions github-actions bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked

Labels to apply: Checklist of common problems not complete, PR description incomplete, Test links missing

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 1/5 checkboxes are not ticked
  FAIL  'Checklist of common problems' section not found
  FAIL  'Online Editor test results' section not found
  FAIL  Template coverage: uspeedo.com.email.json: no editor test link found (expected template id 'uspeedo.com.email')

@github-actions github-actions bot removed the Stale label Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. question Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants