domain connect template for uspeedo.com#701
domain connect template for uspeedo.com#701kiritoaurora wants to merge 7 commits intoDomain-Connect:masterfrom
Conversation
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1032 | mix of empty and defined record groupId values |
|
Could you reconsider use of https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1024 |
@kerolasa I have changed the variable %host% to %subdomain%. Is that okay? |
| { | ||
| "type": "CNAME", | ||
| "groupId": "tracking", | ||
| "host": "%track_host%", |
There was a problem hiding this comment.
is this host under %subdomain%?
If it is the whole template could have used @ instead of %subdomain% and standard host parameter, which has quite benefits - template can be applied several times to the same domain and different subdomains if needed.
Otherwise multiInstance setting might be of help.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->