Skip to content

Add groupId to DNS records for verification#763

Open
aomkoyo wants to merge 26 commits intoDomain-Connect:masterfrom
aomkoyo:master
Open

Add groupId to DNS records for verification#763
aomkoyo wants to merge 26 commits intoDomain-Connect:masterfrom
aomkoyo:master

Conversation

@aomkoyo
Copy link
Contributor

@aomkoyo aomkoyo commented Feb 11, 2026

Description

Enables a domain to work with Furimoe

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.

  • digital signatures are used and syncPubKeyDomain specified (yes, warnPhishing is an option, but some providers reject such templates by policy, so signing shall be a default)
  • syncRedirectDomain is specified when intended to use redirect_uri parameter in the synchronous flow
  • no TXT record with SPF content (i.e. "v=spf1 ...") instead of using SPFM record type on APEX
  • txtConflictMatchingMode is set on TXT records which shall be unique on a label (like DMARC)
  • variables are set to the smallest scope needed (i.e. limit possibility to be misused to set any arbitrary record and conflict with other template). Too broad scope example: @ TXT "%verification%". Better usage: @ TXT "foo-verification=%verification%".
  • no variables as a host name to apply template on subdomain instead of standard host parameter
  • no explicit usage of %host% variable in host attribute
  • essential setting is used on records, which the user shall be able to change or remove manually later without dropping the whole template (like DMARC)

Example variable values

<-- to make review process easier please provide the whole testData object from the Online Editor after testing and using "Add as test" button. Hint: test also with "host" variable set. -->

"testData": {
    "test": {
      "variables": {
        "domain": "furi.moe",
        "host": "furi.moe",
        "group": [
          "subdomain-verification",
          "subdomain",
          "apex"
        ],
        "verifytxt": "c4be57d3-ac64-4a1e-80b3-4d81f047d841",
        "subdomain": "cname",
        "cname": "cname.furi.moe",
        "ip": "192.168.1.1"
      },
      "results": [
        {
          "type": "TXT",
          "name": "_furimoe-challenge.furi.moe",
          "ttl": 60,
          "data": "\"token=c4be57d3-ac64-4a1e-80b3-4d81f047d841\""
        },
        {
          "type": "CNAME",
          "name": "cname.furi.moe",
          "ttl": 600,
          "data": "cname.furi.moe"
        },
        {
          "type": "A",
          "name": "furi.moe",
          "ttl": 600,
          "data": "192.168.1.1"
        }
      ]
    }
  }

@github-actions
Copy link

github-actions bot commented Feb 11, 2026

Linter OK

furimoe.com.domain-verification.json

Level Code Note

Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

"variableDescription": "Unique verification code provided for purpose of verification",
"syncPubKeyDomain": "keys.furimoe.com",
"syncRedirectDomain": "furimoe.com",
"records": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you switch to this model because the verification RR always on apex, consider setting multiInstance unless it's ok to have it applied only once for a domain and any subdomain.

@pawel-kow
Copy link
Member

Please follow the README.md and fill in description as per Template.

@github-actions github-actions bot added the PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. label Mar 4, 2026
@github-actions github-actions bot added the Test links missing No test links from Online Editor provided label Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  Checklist of common problems: 8/8 checkboxes ticked

Labels to add: PR description incomplete, Test links missing
Labels to remove: Checklist of common problems not complete

PR description check FAILED:
  FAIL  'How Has This Been Tested?': 1/5 checkboxes are not ticked
  FAIL  'Online Editor test results' section not found
  FAIL  Template coverage: furimoe.com.domain-verification.json: no editor test link found (expected template id 'furimoe.com.domain-verification')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. question Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants