Skip to content

Add custom domain configuration for Solid App Maker#784

Open
Anshuman200 wants to merge 5 commits intoDomain-Connect:masterfrom
Anshuman200:master
Open

Add custom domain configuration for Solid App Maker#784
Anshuman200 wants to merge 5 commits intoDomain-Connect:masterfrom
Anshuman200:master

Conversation

@Anshuman200
Copy link

This file sets up a custom domain configuration for Solid App Maker, including DNS records for TXT and CNAME types.

Description

<-- short description of the template(s) and/or reason for update -->

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.

  • digital signatures are used and syncPubKeyDomain specified (yes, warnPhishing is an option, but some providers reject such templates by policy, so signing shall be a default)
  • syncRedirectDomain is specified when intended to use redirect_uri parameter in the synchronous flow
  • no TXT record with SPF content (i.e. "v=spf1 ...") instead of using SPFM record type on APEX
  • txtConflictMatchingMode is set on TXT records which shall be unique on a label (like DMARC)
  • variables are set to the smallest scope needed (i.e. limit possibility to be misused to set any arbitrary record and conflict with other template). Too broad scope example: @ TXT "%verification%". Better usage: @ TXT "foo-verification=%verification%".
  • no variables as a host name to apply template on subdomain instead of standard host parameter
  • no explicit usage of %host% variable in host attribute
  • essential setting is used on records, which the user shall be able to change or remove manually later without dropping the whole template (like DMARC)

Example variable values

<-- to make review process easier please provide the whole testData object from the Online Editor after testing and using "Add as test" button. Hint: test also with "host" variable set. -->

"testData": {
    "testingSet": {
      "variables": {
        "domain": "example.com",
        "host": "foo",
        "example": "bar"
      },
      "results": [
        {
          "type": "TXT",
          "name": "foo",
          "ttl": 86400,
          "data": "\"bar\""
        }
      ]
    }
  }

This file sets up a custom domain configuration for Solid App Maker, including DNS records for TXT and CNAME types.
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Linter error

solidappmaker.in.custom_domain.json

Level Code Note
error DCTL0003 json error

@kerolasa kerolasa self-requested a review February 25, 2026 10:27
Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are fair number of issues in the template. Instead of going through each issue one by one could you consider something like the following instead.

{
  "providerId": "solidappmaker.in",
  "providerName": "Solid App Maker",
  "serviceId": "custom_domain",
  "serviceName": "Custom Domain Setup",
  "version": 1,
  "description": "Automatically connects your GoDaddy domain to SolidAppMaker.",
  "syncPubKeyDomain": "dckeys.solidappmaker.in",
  "records": [
    {
      "type": "TXT",
      "host": "%txt_name%",
      "ttl": "3600",
      "data": "%txt_value%"
    },
    {
      "type": "CNAME",
      "host": "%dcv_name%",
      "pointsTo": "%dcv_value%",
      "ttl": "3600"
    },
    {
      "type": "CNAME",
      "host": "%cname_name%",
      "pointsTo": "origin.solidappmaker.in",
      "ttl": "3600"
    }
  ]
}

And please fill the pull request description questionnaire (type of change, testing, common problems).

@github-actions github-actions bot added Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

PR Description Check Failed

The PR description is missing required elements. Please update it according to the PR template.

Details

Labels to apply: Checklist of common problems not complete, PR description incomplete, Test links missing

PR description check FAILED:
  FAIL  'Type of change': no checkboxes are ticked
  FAIL  'How Has This Been Tested?': 5/5 checkboxes are not ticked
  FAIL  'Checklist of common problems': no checkboxes are ticked
  FAIL  'Online Editor test results' section not found
  FAIL  Template coverage: solidappmaker.in.custom_domain.json: no editor test link found (expected template id 'solidappmaker.in.custom_domain')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checklist of common problems not complete See PR template and mark *all* checkboxes, even if not applicable. Explain any discrepancies. PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants