fix(lock): fail closed when owner metadata is unreadable or invalid#226
Open
cursor[bot] wants to merge 1 commit into
Open
fix(lock): fail closed when owner metadata is unreadable or invalid#226cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
3623434 to
e8aaaf6
Compare
Only ENOENT/ENOTDIR during owner.json read means missing metadata. Other errors (e.g. EACCES) or JSON failures propagate; stale removal then refuses to rm and surfaces ResourceLockError instead of deleting a potentially live lock directory. Includes regression tests for chmodded owner.json and broken JSON.
e8aaaf6 to
426174b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes stale-lock recovery so we never treat unreadable or unparsable
owner.jsonas an absent owner. Previously any read or JSON error was swallowed and the lock directory could be removed while mutual exclusion was still required, which risks concurrent lifecycle mutations or inconsistent state.Linked Artifacts
openspec/specs/agent-update/spec.md(lock stale recovery and preserving live locks)Validation
bun run memory:checkbun run lintbun run format:checkbun run typecheckbun run test(if behavior changed)Release Intent
Docs Updated
docs/...openspec/...Scope Check
Closure Check
Notes
Regression coverage includes Unix
chmodremoving read access onowner.json, and invalid JSON contents; both must surfaceResourceLockErrorwithout deleting the lock directory.