ra-rpc: populate Unix peer creds for UDS endpoints#627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes Unix-domain peer credentials to RPC handlers and wires the existing Unix-socket callers to preserve that information.
Changes
UnixPeerCred { pid, uid, gid }tora-rpcRemoteEndpoint::Unixto carrypeer: Option<UnixPeerCred>UnixPeerCredListener, a small Rocket listener wrapper that reads peer credentials from accepted Unix streams viaUnixStream::peer_cred()guest-agent's internal Unix-socket servers so handlers receive peer creds inCallContext.remote_endpointValidation
cargo check -p ra-rpc -p dstack-guest-agentcargo test -p ra-rpccargo clippy -p ra-rpc -p dstack-guest-agent -- -D warningsNotes
RemoteEndpoint::Unix(...); callers need to switch toRemoteEndpoint::Unix { path, peer }.peerremainsNone.