Skip to content

Update README.md, In Pay With Transfer has 'amount' as required parameter and name is not 'required parameter' #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
softmuneeb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md, In Pay With Transfer has 'amount' as required parameter and name is not 'required parameter' #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,8 @@ const payWithTransfer = await fincra.collection.payWithTransfer(data);
| **Parameters** | **Data type** | **Required** | **Description** |
| ------------------- | ------------- | ------------ | --------------------------------------------------------- |
| `expiresAt` | string | true | The expiry of the virtual account in minutes. |
| `name` | string | false | The name that should be on the account. |
| `merchantReference` | string | false | The unique identifier of the transaction on your system . |
Copy link
Copy Markdown
Owner

@E-wave112 E-wave112 Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @softmuneeb

Thanks for the catch!

it would seem that there have been mutliple updates since this method was last updated (even the channel field is required if you are using a NGN account to make the transfer)

Do you think you can dive into the code to update this or you are just okay with updating the README.md(might have to find a weekend to make the update if otherwise)

| `amount` | string | true | The amount to receive from customer. |
| `merchantReference` | string | false | The unique identifier of the transaction on your system. |

#### List Collection for a main Virtual Account

Expand Down