Add some marine variables #131
Conversation
svahl991
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mkavulich,
mwaxmonsky,
nusbaume,
peverwhee and
ss421
as code owners
|
Tagging @travissluka, @shlyaeva, @Dooruk |
|
There's a failing check on this PR that should be resolved by commit 2cfaeb5, but the test didn't get re-triggered. |
|
Note that I'm aware of the apparent inconsistency between adding the names |
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
I have a question about units but this otherwise seems fine.
| </standard_name> | ||
| <standard_name name="sea_water_salinity" | ||
| description="The salinity of sea water"> | ||
| <type units="ppt m">real</type> |
There was a problem hiding this comment.
I am familiar with ppt for seawater salinity but not ppt m. What is this?
There was a problem hiding this comment.
I don't know. (I'm a software engineer, not a scientist, so I'm probably not the best person to create this PR.) It could well be incorrect. I just copied the units in use for the existing sea_water_salinity_in_diurnal_thermocline variable, figuring they would have the same units. But, since I don't understand the diurnal_thermocline part, maybe that's incorrect. I'm happy to correct it to just ppt if needed.
2 participants
Description
We need some marine variables added to the ESM standard since we wish to use them in generic JEDI code for use with SOCA. I have attempted to follow the conventions used for the corresponding
airvariables.Issues
Variables needed for https://github.com/JCSDA-internal/vader/pull/208