14 annual embed#39
Merged
SarahAlidoost merged 10 commits intomainfrom Apr 28, 2026
Merged
Conversation
added 6 commits
April 13, 2026 11:39
…ures to add_month_day_dims, to provide input for temporal encodings
SarahAlidoost
requested changes
Apr 23, 2026
Member
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@meiertgrootes thanks! this is very useful as now the model can capture seasonality/diurnal cycles. I left some comments. The major one is about how the Fourier time encoding is currently implemented, see my comments and let me know if something isn't clear.
Collaborator
|
@meiertgrootes as I indicated in the Teams message I wont have time in the comming days to review this. I am fine with merging on Sarah's approval! |
added 4 commits
April 26, 2026 00:11
…hod phase to embedding. Choice of tropical year as period for basis for doy
Collaborator
Author
|
@SarahAlidoost I've addressed and incorporated your comments. Thanks for the thorough review. |
SarahAlidoost
approved these changes
Apr 28, 2026
Member
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@meiertgrootes Looks very good, Thanks for addressing the comments! 👍 I'll merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces positional encoding in time with a day-of-year (and hour-of-day) based temporal embedding.
This is expected to improve training results, in particular when using multiple years of data.