Fix spurious line breaks in pretty-printing of qualified module paths#898
Merged
strub merged 1 commit intoEasyCrypt:mainfrom Feb 12, 2026
Merged
Fix spurious line breaks in pretty-printing of qualified module paths#898strub merged 1 commit intoEasyCrypt:mainfrom
strub merged 1 commit intoEasyCrypt:mainfrom
Conversation
Remove the `@,` (break hint) from the format string in `pp_msymbol` when printing multi-component module paths. The break hint allowed the formatter to insert line breaks between namespace components, causing output like `G.\nRO.get(x)` or `module Alias = G.\nRO.` instead of the correct `G.RO.get(x)` and `module Alias = G.RO.` Fixes EasyCrypt#696.
Member
|
Note that the way that hint is used by Anyway, since the parser does not support namespace with spaces, the hint is invalid. |
strub
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@,(break hint) from the format string inpp_msymbolwhen printing multi-component module pathsFormatmodule to insert line breaks between namespace components (e.g., betweenG.andRO), producing incorrect outputBefore:
After:
Test plan
Fixes #696.