Eager: match on last statement and use EqTest#900
Open
Cameron-Low wants to merge 1 commit intomainfrom
Open
Conversation
Member
|
@Cameron-Low How eager was working with such a bug? |
Contributor
Author
|
I think just a lack of coverage and the simple usage. I was looking at some more recent examples that involved swapping while statements around when I ran into this; all the other examples were fine. |
Contributor
|
Nice catch! Indeed all examples and uses so far had no duplicate while/if statement on one side, and thus the choice for |
loutr
approved these changes
Feb 13, 2026
strub
requested changes
Feb 14, 2026
Member
strub
left a comment
There was a problem hiding this comment.
Ok for me, but add a test then. This has been unnoticed for too long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two parts:
destruct_op, the split is done on first match: I believe the desired behaviour should be last match.EcReduction.EqTestinstead of base equality.