Skip to content

Conversation

@paullinator
Copy link
Member

@paullinator paullinator commented Dec 23, 2025

Note

Introduces new strings and translation updates across multiple locales (de, es, esMX, fr, it, ja, kaa, ko, pt, ru, vi, zh).

  • Adds gift card marketplace UI strings (gift_card_*, drawer entry) and a new spend_crypto_gift_cards_footer
  • Updates Monero settings: add settings_monero_edge_lws and settings_monero_lws_info; removes MyMonero default text
  • Adds common keys like string_value and string_all
  • Numerous translation fixes and localized replacements (notably Spanish variants)

Written by Cursor Bugbot for commit 9d72d3f. This will update automatically on new commits. Configure here.

"otp_reset_modal_header": "Secure Your Account",
"otp_reset_modal_message": "Two factor authentication (2FA) prevents unauthorized access from other devices, even if your username and password is compromised. You can scan a QR code or type in an authentication code to seamlessly authorize other devices. Would you like to enable 2FA?",
"otp_authentication_header": "Autenticación de dos factores (2FA) activada",
"otp_authentication_message": "La autenticación de dos factores (2FA) ha sido activada. Se ha generado un código de autenticación único. Si pierdes tu teléfono o desinstalas la app, tardará al menos 7 días (hasta 18 meses) en desactivar 2FA y acceder a tu cuenta desde otro dispositivo sin el siguiente código de autenticación",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing format specifier for 2FA code display

The Spanish translation of otp_authentication_message is missing the \n\n%s format specifier at the end of the string. The English original includes this to display the actual 2FA backup authentication code to users. Without it, Spanish-speaking users who enable 2FA won't see their backup code in the confirmation message, which is critical for account recovery if they lose their device.

Fix in Cursor Fix in Web

"settings_monero_edge_lws": "Edge LWS",
"settings_monero_custom": "Custom Light Wallet Server",
"settings_monero_info": "Edge uses Monero light wallet servers provided by MyMonero. These servers hold the private view key, which they use to scan for transactions. For enhanced privacy, you can run your own Monero light wallet server.",
"settings_monero_lws_info": "Edge uses Monero Light Wallet Servers (LWS) to scan for transactions. For enhanced privacy, you can run your own Monero LWS.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation keys renamed but code still uses old keys

Medium Severity

The translation files rename settings_monero_default to settings_monero_edge_lws and settings_monero_info to settings_monero_lws_info, but the code in MaybeMoneroUserSettings.tsx still references lstrings.settings_monero_default and lstrings.settings_monero_info, and the English source files (en_US.ts, enUS.json) retain the old key names. This causes non-English users to see English fallback text instead of their translated text for Monero settings, since the keys the code looks up no longer exist in the localized files.

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants