Skip to content

npm: invalid package dependency#43

Merged
Ekliptor merged 2 commits intoEkliptor:masterfrom
kirschte:package
Dec 16, 2019
Merged

npm: invalid package dependency#43
Ekliptor merged 2 commits intoEkliptor:masterfrom
kirschte:package

Conversation

@kirschte
Copy link
Copy Markdown
Contributor

In #1 (comment) you mentioned that this should be fixed, but as of today this issue is still present when using npm.

@Ekliptor
Copy link
Copy Markdown
Owner

Ekliptor commented Dec 15, 2019

Hi,
thanks for the PR.
However, we need to use genetic JS from this pull request to support async evolution: subprotocol/genetic-js#14

Unfortunately they still haven't merged this into their master branch. yarn install works with this dependency to the PR. Do you know of a syntax to make a dependency to a PR that works with yarn and npm ?

Update: as mentioned in the linked PR, there is a fork supporting async evolution that also ported it to TypeScript. If the API is the same we can switch to that dependency.

@kirschte
Copy link
Copy Markdown
Contributor Author

kirschte commented Dec 15, 2019

Oh, I didn't notice that the async functionality went missing. o_O

Inspired by https://stackoverflow.com/a/33183255/6396693 one could actually reference the original branch instead of the PR (in this case the master branch of the fork from the PR-owner). As long as the maintainer doesn't remove it, it should be the same functionality working fine with npm and yarn (as of now only tested with npm though).

Using the typescript version could in the long term also be interesting, this fix is definitely safer though and would, in the end, reenable npm-support instantaneously. :)

@Ekliptor Ekliptor merged commit 90fab00 into Ekliptor:master Dec 16, 2019
@Ekliptor
Copy link
Copy Markdown
Owner

i can confirm it also works with yarn. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants