Fix mixed-argument type errors in create_mailer and compose_email by Copilot · Pull Request #26 · ElefantOne/do-functions-php-send-email

Copilot · 2026-02-18T10:31:45Z

Mago static analyzer reported 9 type errors where $args array access returned mixed instead of expected scalar/string types, causing failures in sprintf() and Address constructor calls.

Changes

Added inline type assertions to extract and explicitly type array values:

function create_mailer(array $args): Mailer
{
    // Type assertions for mago analyzer
    /** @var string $username */
    $username = $args['smtp_username'];
    /** @var string $password */
    $password = $args['smtp_password'];
    /** @var string $server */
    $server = $args['smtp_server'];
    /** @var int|string $port */
    $port = $args['smtp_port'];
    
    $dsn = sprintf('smtp://%s:%s@%s:%s', $username, $password, $server, $port);
    // ...
}

Same pattern applied to compose_email() for email address and subject parameters.

Result

Errors: 9 → 0
Warnings: 4 → 4 (pre-existing, unrelated)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/carthage-software/mago/releases
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/2fzXLd /usr/bin/composer mago:install-binary credential.username 41e5fa90^{commit} (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/Qn24aR /usr/bin/composer mago:install-binary -- de/node/bin/git en --verify it e/git clon�� --no-checkout /home/REDACTED/.cache/composer/vcs--reference rgo/bin/git ce-contracts.gitgit --reference /home/REDACTED/.caset-url git (http block)
https://api.github.com/repos/carthage-software/mago/zipball/b50e6aa3e4e6abe144101720deddbf456cb7e0a1
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/doctrine/lexer/zipball/31ad66abc0fc9e1a1f2d9bc6a42668d2fbbcd6dd
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/egulias/EmailValidator/zipball/d42c8731f0624ad6bdc8d3e5e9a4524f68801cfa
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/guzzle/guzzle/zipball/b51ac707cfa420b7bfd4e4d5e510ba8008e822b4
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/guzzle/promises/zipball/481557b130ef3790cf82b713667b43030dc9c957
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/guzzle/psr7/zipball/21dc724a0583619cd1652f673303492272778051
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/container/zipball/c71ecc56dfe541dbd90c5360474fbc405f8d5963
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/event-dispatcher/zipball/dbefd12671e8a14ec7f180cab83036ed26714bb0
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/http-client/zipball/bb5906edc1c324c9a05aa0873d40117941e5fa90
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/http-factory/zipball/2b4765fddfe3b508ac62f829e852b1501d3f6e8a
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/http-message/zipball/402d35bcb92c70c026d1a6a9883f06b2ead23d71
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/php-fig/log/zipball/f16e1d5863e37f8d8c2a01719f5b34baa2b714d3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/ralouphie/getallheaders/zipball/120b605dfeb996808c31b6477290a714d356e822
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/deprecation-contracts/zipball/63afe740e99a13ba87ec199bb07bbdee937a5b62
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/event-dispatcher-contracts/zipball/59eb412e93815df44f05f342958efa9f46b1e586
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/event-dispatcher/zipball/b7dc69e71de420ac04bc9ab830cf3ffebba48191
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/mailer/zipball/fd497c45ba9c10c37864e19466b090dcb60a50ba
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/mime/zipball/b1b828f69cbaf887fa835a091869e55df91d0e35
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-ctype/zipball/a3cc8b044a6ea513310cbd48ef7333b384945638
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-idn/zipball/9614ac4d8061dc257ecc64cba1b140873dce8ad3
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-intl-normalizer/zipball/3833d7255cc303546435cb650316bff708a1c75c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/polyfill-mbstring/zipball/6d857f4d76bd4b343eac26d6b539585d2bc56493
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/symfony/service-contracts/zipball/f021b05a130d35510bd6b25fe9053c2a8a15d5d4
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
https://api.github.com/repos/twigphp/Twig/zipball/a64dc5d2cc7d6cafb9347f6cd802d0d06d0351c9
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/6RNXma /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/BlfTUi /usr/bin/composer install --prefer-dist --no-progress --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Fix issues</issue_title>
<issue_description>```
error[mixed-argument]: Invalid argument type for argument #2 of sprintf: expected `Stringable|null|scalar`, but found `mixed`.
┌─ index.php:193:9
│
191 │ $dsn = sprintf(
│ ------- Arguments to this function are incorrect
192 │ '***%s:%s',
193 │ $args['smtp_username'],
│ ^^^^^^^^^^^^^^^^^^^^^^ Argument has type `mixed`
│
= The type `mixed` is too general and does not match the expected type `Stringable|null|scalar`.
= Help: Add specific type hints or assertions to the argument value.

error[mixed-argument]: Invalid argument type for argument #3 of sprintf: expected Stringable|null|scalar, but found mixed.
┌─ index.php:194:9
│
191 │ $dsn = sprintf(
│ ------- Arguments to this function are incorrect
·
194 │ $args['smtp_password'],
│ ^^^^^^^^^^^^^^^^^^^^^^ Argument has type mixed
│
= The type mixed is too general and does not match the expected type Stringable|null|scalar.
= Help: Add specific type hints or assertions to the argument value.

error[mixed-argument]: Invalid argument type for argument #4 of sprintf: expected Stringable|null|scalar, but found mixed.
┌─ index.php:195:9
│
191 │ $dsn = sprintf(
│ ------- Arguments to this function are incorrect
·
195 │ $args['smtp_server'],
│ ^^^^^^^^^^^^^^^^^^^^ Argument has type mixed
│
= The type mixed is too general and does not match the expected type Stringable|null|scalar.
= Help: Add specific type hints or assertions to the argument value.

error[mixed-argument]: Invalid argument type for argument #5 of sprintf: expected Stringable|null|scalar, but found mixed.
┌─ index.php:196:9
│
191 │ $dsn = sprintf(
│ ------- Arguments to this function are incorrect
= Using mixed can lead to runtime errors if the variable is used in a way that assumes a specific type.
= Help: Consider using a more specific type to avoid potential issues.

error: found 13 issues: 9 error(s), 4 warning(s)
## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes Fix issues #25

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: egorsmkv <7875085+egorsmkv@users.noreply.github.com>

Initial plan

f10a0a8

Copilot AI assigned Copilot and egorsmkv Feb 18, 2026

Copilot started work on behalf of egorsmkv February 18, 2026 10:32 View session

Copilot AI and others added 2 commits February 18, 2026 10:35

Add specific type annotations to fix mixed-argument errors

7d3edf8

Co-authored-by: egorsmkv <7875085+egorsmkv@users.noreply.github.com>

Use type assertions to fix all mixed-argument errors

b47699a

Co-authored-by: egorsmkv <7875085+egorsmkv@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix invalid argument types for sprintf in index.php~~ Fix mixed-argument type errors in create_mailer and compose_email Feb 18, 2026

Copilot AI requested a review from egorsmkv February 18, 2026 10:41

Copilot finished work on behalf of egorsmkv February 18, 2026 10:41

egorsmkv marked this pull request as ready for review February 18, 2026 11:01

egorsmkv merged commit 1366540 into main Feb 18, 2026
1 check passed

egorsmkv deleted the copilot/fix-sprintf-argument-types branch February 18, 2026 11:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix mixed-argument type errors in create_mailer and compose_email#26

Fix mixed-argument type errors in create_mailer and compose_email#26
egorsmkv merged 3 commits intomainfrom
copilot/fix-sprintf-argument-types

Copilot AI commented Feb 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Result

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 18, 2026 •

edited

Loading