information schema tables, columns, schemas, views per specific catalog#21
information schema tables, columns, schemas, views per specific catalog#21osipovartem wants to merge 3 commits intoembucket-sync-df47.0.0from
Conversation
|
What about an option to have information_schema implementation exclusively in the main repo? Such that there is no dependency on upstream? Information schema could be considered as part of catalog and datafusion recommends each database has its own catalog implementation. Information schema could be viewed as a reference implementation in datafusion and perhaps it's quite okay to have separate implementation? |
In this case we have to make the list of existing builders public and just rewrite 3-4 of them to fetch data per catalog. In this case we can update it according to snowflake implementation. |
Yes, I was suggesting something like this. I am not yet sure how complex information schema support could be, but perhaps having started with a copy paste as initial implementation is not the craziest idea. |
|
Should it be closed due to Embucket/embucket#718 ? |
Which issue does this PR close?
Rationale for this change
According to Postgres docs information_schema.tables should contain all tables and views defined in the current database, not from all catalogs
The same for columns, schemas, views
What changes are included in this PR?
Use resolved table reference to get catalog name and pass it to InformationSchemaProvider builder to fetch tables for only this particular catalog instead of all catalogs
Are these changes tested?
Tested localy
Are there any user-facing changes?
No