forked from PufferAI/PufferLib
-
Notifications
You must be signed in to change notification settings - Fork 24
WIP: merge turbostream DO NOT MERGE #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eugenevinitsky
wants to merge
24
commits into
2.0
Choose a base branch
from
2.0_v2
base: 2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
188cf58
Merge turbostream (vcha/turbostream) into 2.0_v2
eugenevinitsky 99d6d47
Add cluster configs from 3.0, update map_dir for turbostream
eugenevinitsky e03c848
Add MPLCONFIGDIR to scratch cache exports in submit_cluster.py
eugenevinitsky b0d6294
Add --wandb-name argument support to pufferl.py
eugenevinitsky db84939
Add visualize.c from turbostream (was missed in initial merge)
eugenevinitsky bbd8d77
Fix visualize.c struct fields to match turbostream drive.h
eugenevinitsky fc54f7c
Fix distance_since_spawn: accumulate sim_speed * dt each step
eugenevinitsky 6d4cd71
Add missing import pufferlib.utils in pufferl.py
eugenevinitsky 4806ad5
Auto-discover map files for rendering instead of using map_%03d.bin f…
eugenevinitsky 91aa2c1
Point render_map at actual Carla Town01 binary
eugenevinitsky 41cba0f
Fix formatting (ruff) and relax matplotlib pin
eugenevinitsky b1e529d
Restrict clang-format hook to C/C++ files only
eugenevinitsky baa3fff
Fix render pipeline: pass weights via --policy-name, use absolute out…
eugenevinitsky dbb7c43
Fix stale expected_weights_path ref, add visualize stderr logging
eugenevinitsky 51f9722
Fix visualize build: add include guards to drive.h, add drive.h inclu…
eugenevinitsky 7fb53ad
Fix visualize: default to 32 agents, pass missing config fields
eugenevinitsky 6d99aa8
Make symlog reward transform optional, off by default
eugenevinitsky 5967260
Rewrite drivenet.h to match turbostream architecture, fix rendering
eugenevinitsky a4a1cee
Fix ini parser: return 1 (skip) for unknown sections instead of 0 (er…
eugenevinitsky 897997b
Warn on unknown keys in [env] section, skip other sections silently
eugenevinitsky 5104a9d
Build visualize with fast mode (no ASAN), fix ini parser for non-env …
eugenevinitsky 6e40e7b
Increase render timeout from 120s to 600s
eugenevinitsky e84c9a6
Check if video files exist regardless of exit code for wandb logging
eugenevinitsky c3f3082
Always log visualize exit code and output on non-zero return
eugenevinitsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ name: perf-ci | |
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ 2.0 ] | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| test-performance: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Pre-commit | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - reopened | ||
| - synchronize | ||
| - ready_for_review | ||
|
|
||
| jobs: | ||
| pre-commit: | ||
| name: pre-commit | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install pre-commit | ||
| run: python -m pip install -U pip pre-commit | ||
|
|
||
| - name: Run pre-commit | ||
| run: pre-commit run --all-files --show-diff-on-failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| name: render-ci | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ main ] | ||
| push: | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| test-render: | ||
| name: test-render - ubuntu-latest | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Check disk space (before cleanup) | ||
| run: df -h | ||
|
|
||
| - name: Free up disk space | ||
| run: | | ||
| echo "Before cleanup:" | ||
| df -h | ||
| sudo rm -rf /usr/share/dotnet /usr/local/lib/android /opt/ghc | ||
| sudo apt-get clean | ||
| sudo rm -rf ~/.cache/pip /tmp/* /var/tmp/* | ||
| echo "After cleanup:" | ||
| df -h | ||
|
|
||
| - name: Install system dependencies for headless rendering | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y ffmpeg xvfb build-essential | ||
|
|
||
| - name: Upgrade pip | ||
| run: python -m pip install -U pip | ||
|
|
||
| - name: Install pufferlib | ||
| run: | | ||
| pip install -e .[cpu] --no-cache-dir | ||
| env: | ||
| TMPDIR: ${{ runner.temp }}/build | ||
| PIP_NO_CACHE_DIR: 1 | ||
|
|
||
| - name: Compile C extensions | ||
| run: python setup.py build_ext --inplace --force | ||
|
|
||
| - name: Check disk space (after install) | ||
| run: df -h | ||
|
|
||
| - name: Run render test | ||
| run: python tests/test_drive_render.py | ||
| timeout-minutes: 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Training Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - closed | ||
| branches: [ develop ] | ||
|
|
||
| jobs: | ||
| run-training-test: | ||
| name: Run Training Test | ||
| if: github.event.pull_request.merged == true | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Authenticate to Google Cloud | ||
| uses: 'google-github-actions/auth@v2' | ||
| with: | ||
| credentials_json: '${{ secrets.GCP_CREDENTIALS }}' | ||
|
|
||
| - name: Configure Docker for GCP Artifact Registry | ||
| run: gcloud auth configure-docker europe-west4-docker.pkg.dev | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install dependencies for mlops.py | ||
| run: pip install pyyaml google-cloud-aiplatform | ||
|
|
||
| - name: Run training test | ||
| run: python mlops/mlops.py train-test --verbose | ||
| timeout-minutes: 40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prior
excludepattern for clang-format was removed, which means clang-format will now run on file types/paths that were previously excluded (e.g., large generated/build or non-C/C++ directories). If those directories still exist in the repo, reinstating anexclude(or narrowingfiles:) will avoid unnecessary work and reduce the chance of formatting unintended assets.