Improve behaviour of the "on" lint#264
Open
gitnik wants to merge 1 commit intoEmmanuelDemey:developmentfrom
Open
Improve behaviour of the "on" lint#264gitnik wants to merge 1 commit intoEmmanuelDemey:developmentfrom
gitnik wants to merge 1 commit intoEmmanuelDemey:developmentfrom
Conversation
gitnik
commented
Nov 13, 2015
- The lint will from now on only handle "$on" calls, as "$watches" are automatically removed upon destroying the scope. I therefore also changed the name of the lint to match what is does.
- The lint will no longer complain about not unsubscribing from the $rootScope. While there can be cases where this is valid, most of the time it isn't
- Adapt tests
- Adapt documentation
* The lint will from now on only handle "$on" calls, as "$watches" are automatically removed upon destroying the scope. * The lint will no longer complain about not unsubscribing from the $rootScope. While there can be cases where this is valid, most of the time it isn't * Adapt tests * Adapt documentation
Closed
Author
|
Fixes #231 |
Owner
|
Can you do your PR on the development branch? Thanks by the way ;) |
|
Any reason not to do this? |
|
@gitnik any plan to work on this one? Thanks |
|
Would love to see this |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.