Replace RSAEncrypt with SSHKeyPair supporting Ed25519/ECDSA/RSA#1414
Merged
LadyCailin merged 1 commit intomasterfrom Apr 7, 2026
Merged
Replace RSAEncrypt with SSHKeyPair supporting Ed25519/ECDSA/RSA#1414LadyCailin merged 1 commit intomasterfrom
LadyCailin merged 1 commit intomasterfrom
Conversation
Member
LadyCailin
commented
Apr 7, 2026
LadyCailin
commented
- Replace RSAEncrypt with SSHKeyPair, which uses java.security.Signature (sign/verify) instead of Cipher (encrypt/decrypt), enabling support for Ed25519 and ECDSA in addition to RSA
- Update DebugAuthenticator to use SSHKeyPair.verify()
- Update key-gen tool with -t flag for key type selection (default: Ed25519), dynamically listing supported types from the KeyType enum
- Replace RSAEncryptTest with parameterized SSHKeyPairTest covering all three key types
- Only advertise declaration, definition, and hover LSP capabilities when StaticAnalysis is globally enabled, fixing spurious "error analyzing included file" diagnostics for users with SA off
- Remove setLocalEnable(true) calls from LangServModel that were forcing SA on regardless of user config
- Replace RSAEncrypt with SSHKeyPair, which uses java.security.Signature (sign/verify) instead of Cipher (encrypt/decrypt), enabling support for Ed25519 and ECDSA in addition to RSA - Update DebugAuthenticator to use SSHKeyPair.verify() - Update key-gen tool with -t flag for key type selection (default: Ed25519), dynamically listing supported types from the KeyType enum - Replace RSAEncryptTest with parameterized SSHKeyPairTest covering all three key types - Only advertise declaration, definition, and hover LSP capabilities when StaticAnalysis is globally enabled, fixing spurious "error analyzing included file" diagnostics for users with SA off - Remove setLocalEnable(true) calls from LangServModel that were forcing SA on regardless of user config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.