Refactor: Fix Infrastructure and Design Code Smells for Improved Maintainability#2928
Open
Gautham-2907 wants to merge 4 commits intoEngineHub:version/7.4.xfrom
Open
Refactor: Fix Infrastructure and Design Code Smells for Improved Maintainability#2928Gautham-2907 wants to merge 4 commits intoEngineHub:version/7.4.xfrom
Gautham-2907 wants to merge 4 commits intoEngineHub:version/7.4.xfrom
Conversation
…plaining variable, replace conditional with polymorphism - Add ChunkFromTagLoader interface and ChunkFromTagLoaders with format-specific loaders (code smell: long conditional chain) - Extract extractDataVersion() and applyDataFixerIfNeeded() to reduce method size - Introduce explaining variables isMcAFormat, isBehindCurrentVersion, shouldApplyFix - Replace version if-else chain with ChunkFromTagLoaders.loadChunk()
…ponents - Code smell: duplicated path computation in getFilename and getChunkData - Add getChunkPathComponents(BlockVector2) and ChunkPathComponents record - Both getFilename and getChunkData now use getChunkPathComponents
- Code smell: LocalSession had mixed responsibilities (session + CUI state) - Add SessionCUIState holding failedCuiAttempts, hasCUISupport, cuiVersion, serverCuiStructureBlockPosition - LocalSession delegates CUI state getters/setters to cuiState; onIdle() calls cuiState.reset()
- Code smell: unclear names. Rename pickaxeMode to superPickaxeTool - Extract isSelectionDefinedForWorld(World) and use in getSelection() to decompose complex conditional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Infrastructure and Design code smells identified in the WorldEdit codebase through targeted refactoring.
Changes Made
Files Changed
EditSession.java, etc.]Testing
Notes
Happy to revise based on maintainer feedback.