Skip to content

feat(types): Add feature to RLP encode contract events.#279

Closed
n-puzankov-supra wants to merge 8 commits intodevfrom
implement-rlp-encoding-for-contract-events
Closed

feat(types): Add feature to RLP encode contract events.#279
n-puzankov-supra wants to merge 8 commits intodevfrom
implement-rlp-encoding-for-contract-events

Conversation

@n-puzankov-supra
Copy link
Copy Markdown

@n-puzankov-supra n-puzankov-supra commented Aug 29, 2025

This PR is part of the PR-1996.

@n-puzankov-supra n-puzankov-supra self-assigned this Aug 29, 2025
@n-puzankov-supra n-puzankov-supra force-pushed the implement-rlp-encoding-for-contract-events branch 5 times, most recently from 766bcb0 to 16cbf0d Compare September 5, 2025 09:57
@n-puzankov-supra n-puzankov-supra force-pushed the implement-rlp-encoding-for-contract-events branch from 16cbf0d to 2b212fd Compare October 6, 2025 10:40
@n-puzankov-supra n-puzankov-supra requested a review from a team October 6, 2025 10:42
@n-puzankov-supra n-puzankov-supra force-pushed the implement-rlp-encoding-for-contract-events branch 4 times, most recently from 2fd5070 to cf2ae69 Compare October 7, 2025 12:16
… events emissions proofs.

- RLP's `Encodable` trait implementation for Contract Events.
- `get_proof_by_position` method for Merkle Accumulator.
@n-puzankov-supra n-puzankov-supra force-pushed the implement-rlp-encoding-for-contract-events branch from cf2ae69 to c3f6e9f Compare October 7, 2025 12:34
@vpanchal-supra vpanchal-supra force-pushed the implement-rlp-encoding-for-contract-events branch from 73fbe23 to 6fd76be Compare January 27, 2026 08:50
Copy link
Copy Markdown

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

Comment on lines +51 to +63
mod tests {
#[cfg(feature = "rest_api_schema")]
#[test]
fn feature() {
use crate::proof::{AccumulatorProof, TransactionAccumulatorHasher};

#[derive(utoipa::ToSchema)]
pub struct TransactionInclusionProof {
#[schema(value_type = AccumulatorProof<u64>)]
pub proof: AccumulatorProof<TransactionAccumulatorHasher>,
}
}
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this code for?

@vpanchal-supra
Copy link
Copy Markdown

This PR has been superseded by PR #341. Closing this PR.

@vpanchal-supra vpanchal-supra self-assigned this Mar 5, 2026
@vpanchal-supra vpanchal-supra added the enhancement New feature or request label Mar 5, 2026
@vpanchal-supra vpanchal-supra deleted the implement-rlp-encoding-for-contract-events branch March 5, 2026 07:11
@vpanchal-supra vpanchal-supra restored the implement-rlp-encoding-for-contract-events branch March 5, 2026 11:31
@vpanchal-supra vpanchal-supra deleted the implement-rlp-encoding-for-contract-events branch March 5, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants