fix: add a optimization barrier to prevent folding#2367
Open
fix: add a optimization barrier to prevent folding#2367
Conversation
wsmoses
reviewed
Mar 31, 2026
| auto newConstant = | ||
| stablehlo::ConstantOp::create(rewriter, op.getLoc(), splatAttr); | ||
| // Insert a optimization barrier to prevent the constant from being folded | ||
| auto barrier = stablehlo::OptimizationBarrierOp::create( |
Member
There was a problem hiding this comment.
Can you explain why we want this?
Collaborator
Author
There was a problem hiding this comment.
This is effectively a "this large constant makes the file too big to load, so lets do an illegal transform to make it readable". Once we remove the large non-splatted constant there is now a chance that the new constant gets folded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.