Skip to content

Explicitly annotate non-person etymology #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbelien merged 1 commit into from
Sep 17, 2025
Merged

Explicitly annotate non-person etymology #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Command/GeoJSONCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@
$_person = array_unique(array_column($detailsEtymology, 'person'));
$_gender = array_unique(array_column($detailsEtymology, 'gender'));

$genderEtymology = (count($_person) === 1 && current($_person) === true) ? (count($_gender) === 1 ? current($_gender) : '+') : false;
$genderEtymology = (count($_person) === 1 && current($_person) === true) ? (count($_gender) === 1 ? current($_gender) : '+') : '-';

if (count($detailsEtymology) === 1) {
$detailsEtymology = current($detailsEtymology);
Expand Down Expand Up @@ -433,7 +433,7 @@
$_person = array_unique(array_column($detailsWikidata, 'person'));
$_gender = array_unique(array_column($detailsWikidata, 'gender'));

$genderWikidata = (count($_person) === 1 && current($_person) === true) ? (count($_gender) === 1 ? current($_gender) : '+') : false;
$genderWikidata = (count($_person) === 1 && current($_person) === true) ? (count($_gender) === 1 ? current($_gender) : '+') : '-';

if (count($detailsWikidata) === 1) {
$detailsWikidata = current($detailsWikidata);
Expand Down Expand Up @@ -518,7 +518,7 @@
/** @var Relation */ $object = $object;
/** @var Member[] */ $members = [];

switch ($object->tags->type) {

Check failure on line 521 in Command/GeoJSONCommand.php

View workflow job for this annotation

GitHub Actions / PHPStan 

Cannot access property $type on object|null.
case 'associatedStreet':
case 'street':
$members = array_filter(
Expand Down Expand Up @@ -554,7 +554,7 @@
}
break;
default:
$warnings[] = sprintf('<warning>Type "%s" is not supported (yet) for relation(%d).</warning>', $object->tags->type, $object->id);

Check failure on line 557 in Command/GeoJSONCommand.php

View workflow job for this annotation

GitHub Actions / PHPStan 

Cannot access property $type on object|null.
break;
}

Expand Down
Loading