Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have made the modifications based on your suggestions, but I encountered several issues. Some of the tests in the book appear to be insufficient; for instance, the code examples do not take WASM compatibility into account. Many examples from the book might fail to run in a WASM environment.
Specifically, the
df-interchange = { version = "0.3", features = ["polars_0_50", "polars_0_51"] }dependency inCargo.tomllikely won't compile under WASM. Furthermore, the Polars parquet feature has known issues in WASM environments (for details, please refer to Polars Issue #25857).Additionally, the plotting data used in the book is plotlars-specific. It is only suitable for a few specific types of charts and contains a large number of repetitive integers, making it poor input data for Charton. Therefore, I decided to use Charton's built-in data for the user demonstrations and avoid compatibility issues among different polars versions (In fact, Charton uses
polars-ioparquet series, notpolarsparquet feature to bridge the dataframe among these versions, which can be found in charton's tutorial). This ensures users realize that Charton is a powerful, viable alternative to Plotlars for data visualization.I have submitted a new Pull Request. After weighing all factors, I believe this Pull Request represents the most straightforward approach. Otherwise, both of us would need to make significant revisions to the book's content, which wouldn't be cost-effective for either of us. I hope you will take these factors into consideration.