GH-304 Fix Folia enderpearl inflicting self damage on user

[CitralFlo]

Reported via Discord.

[gemini-code-assist]

Summary of Changes

Hello @CitralFlo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a specific bug on Folia servers where enderpearl usage would erroneously trigger self-damage and combat tagging. Beyond the bug fix, it enhances the combat system by introducing configurable bypass mechanisms for administrators, creative mode players, and those with a designated permission, providing more granular control over combat tagging behavior. Additionally, it includes necessary dependency adjustments and build script updates to ensure compatibility and leverage newer plugin versions.

Highlights

• Folia Enderpearl Self-Damage Fix: Resolved an issue where players on Folia servers would incorrectly take self-damage and get combat tagged when using enderpearls, by adding a specific check to prevent self-tagging.
• Combat Tag Bypass Mechanisms: Introduced new dedicated controllers allowing administrators, creative mode players, or players with a specific permission to bypass combat tagging, providing more granular control over combat behavior.
• Dependency Updates and Build Configuration: Downgraded the LITE_COMMANDS dependency to ensure compatibility with Folia and updated various other plugin versions and build task configurations for development environments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where enderpearls could inflict self-damage on Folia servers, and refactors the combat bypass logic into separate, more maintainable controller classes. The changes look good, but I've found a critical issue with how UUIDs are compared, which could lead to bugs. I've also suggested a refactoring to reduce code duplication in the new bypass controllers.

[CitralFlo]

Should be merged after: #302

[Jakubk15]

I assume this won't only be the cause for Ender Pearls, right? The if condition will also be met when, for example, a player shoots an arrow into the air and it hits them?

[CitralFlo]

True, I couldn't figure out other scenarios.
The ender pearl scenario does not even contain the type / cause / source using bukkit methods. I will verify that and complete a fix.

Thanks for the scenario!