Skip to content

Conversation

@GernotMaier
Copy link
Member

No description provided.

@GernotMaier GernotMaier self-assigned this Jan 29, 2026
@GernotMaier GernotMaier requested a review from Copilot January 30, 2026 14:26
@GernotMaier GernotMaier marked this pull request as ready for review January 30, 2026 14:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR transitions the classification BDT training from separate models for each telescope multiplicity (2, 3, 4 telescopes) to a single unified model trained on all telescope multiplicities. This architectural change simplifies the model structure and is reflected in the VTS (Variable Telescope System) implementation.

Changes:

  • Updated model configuration structure to remove telescope multiplicity nesting level
  • Added core position features (Xcore, Ycore) to classification features
  • Implemented conditional handling of size-related variables based on analysis type
  • Updated documentation to reflect single BDT training approach

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/eventdisplay_ml/scripts/train_xgb_classify.py Updated docstring to reflect training a single BDT for all telescope multiplicities
src/eventdisplay_ml/models.py Removed telescope multiplicity level from model configuration structure when collecting threshold keys
src/eventdisplay_ml/features.py Added size to telescope features and Xcore/Ycore to classification features; updated comments to clarify size usage
src/eventdisplay_ml/data_processing.py Added analysis_type parameter to flatten_telescope_variables; implemented conditional logic to handle size-related variables differently for classification vs stereo_analysis

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GernotMaier GernotMaier merged commit ece4ae1 into main Jan 30, 2026
2 checks passed
@GernotMaier GernotMaier deleted the classifier-with-sorted-size branch January 30, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants