Add support for nested SubMenus #1005
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I just realized this definitely conflicts with my last pull request. Should I worry about this or that's not my responsibility? |
maddie480-bot
added
the
review needed
Member
|
Don't worry about conflicts until one of the two gets merged. We will simply rebase onto dev once one is merged. |
ACherryJam
force-pushed
the
add-nested-submenus
branch
from
f62f03f to
377d1d5
Compare
Contributor
Author
|
Rebased the branch, ready for review. |
Member
|
Assigning myself to remind myself to review this in the (hopefully near) future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for nested
SubMenus.Every
SubMenunow stores aParentsubmenu. If theParentisnullthe submenu is added toTextMenu,Container'sFocused,AutoScrollfields andMoveSelectionmethod should be used. Otherwise we do the same things but for theParent.To keep parent
SubMenuvisible while not in focus,ItemsVisibleflag was added.Mod example: NestedSubMenuExample.zip
8mb.video-a8J-VS9ioLQK.mp4