Improvement: protect plan files from review deletion #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2026 14:03
The review/resolve pipeline could flag docs/plans/*.md and docs/solutions/*.md files for deletion, contradicting /workflows:work which treats them as living documents. Adds protection at three layers: - review.md: Protected Artifacts section + synthesis filter - code-simplicity-reviewer.md: YAGNI exception for pipeline artifacts - resolve_todo_parallel.md: Safety check to skip/wont_fix such todos Fixes EveryInc#140
The review/resolve pipeline could flag docs/plans/*.md and docs/solutions/*.md files for deletion, contradicting /workflows:work which treats them as living documents. Adds protection at four layers: - review.md: Protected Artifacts section and synthesis filter - code-simplicity-reviewer.md: YAGNI exception for pipeline artifacts - resolve_todo_parallel.md: Skip and wont_fix todos targeting these paths - git-history-analyzer.md: Note not to characterize them as unnecessary Fixes EveryInc#140
Collaborator
|
TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The review/resolve pipeline can delete plan files created by
/workflows:plan.Note: this might be heavy-handed, so I'm open to feedback. But deleting such a valuable artifact seems like a no-no :)
When running the full pipeline (plan → work → review → resolve → compound), the review step's parallel agents — specifically
code-simplicity-reviewer(YAGNI) andgit-history-analyzer— can flagdocs/plans/*.mdfiles as unnecessary cleanup candidates. The resolve step then executes those findings, deleting the plan file and addingdocs/plans/to.gitignore.This directly contradicts
/workflows:work, which treats plans as living documents and checks off tasks inside them as work progresses.Fix
Rather than a single guardrail that could be bypassed, this adds protection at four layers in the pipeline:
commands/workflows/review.mdagents/review/code-simplicity-reviewer.mddocs/plans/anddocs/solutions/agents/research/git-history-analyzer.mdcommands/resolve_todo_parallel.mdwont_fixany todo targeting these pathsThe same protection covers
docs/solutions/*.mdsince those are also pipeline-managed artifacts.Testing
This was discovered while running the full compound-engineering pipeline on a fresh Rails project. The plan file (
docs/plans/2026-01-31-feat-projects-crud-plan.md, 750 lines) was deleted by the resolve step after being flagged as P3 cleanup by two review agents.Workaround (adding a note to
CLAUDE.md) confirmed the root cause — agents respect explicit instructions but had no built-in awareness of pipeline artifacts.Fixes #140