Draft
Conversation
This change adds variable passing via environment variables. It is useful for passing secrets into the script. If the secrets are passed inplace, systems like defender can log the execution of the script and therefore save the cleartext secret. Passing ENVs via ssh must be enabled on the ssh server side. To avoid a mixup with existing ENVs, a prefix can be defined and is set as default. This also avoids some attacks when allowing to set ENVs, because the pattern in the server can be configured to only match the prefix defined in the connector config. The new feature is only availablen for variables-bash and variables-powershell.
Author
|
@matusmacik what do you think about this idea? |
Contributor
|
Thank you for the contribution. I don't see any issue with this; the original functionality is being preserved as the default, and this seems to be a valid use case. Any time you are ready, switch the PR to ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds variable passing via environment variables. It is useful for passing secrets into the script. If the secrets are passed inplace, systems like defender can log the execution of the script and therefore save the cleartext secret.
Passing ENVs via ssh must be enabled on the ssh server side. To avoid a mixup with existing ENVs, a prefix can be defined and is set as default. This also avoids some attacks when allowing to set ENVs, because the pattern in the server can be configured to only match the prefix defined in the connector config.
The new feature is only availablen for variables-bash and variables-powershell.