Conversation
1azyman
left a comment
1azyman
left a comment
There was a problem hiding this comment.
Hi, code looks fine, I noticed just one thing with ordering. Please have a look at it, maybe it can be removed and sorting have to take into account "null" order values...which I think it does. Thank you very much.
| return searchItems; | ||
| } | ||
|
|
||
| private static List<SearchItemType> getSearchItemsWithDisplayOrder(SearchItemsType searchItems) { |
There was a problem hiding this comment.
I think it would be a bit safer not to mutate custom search items displayOrder. What if user set order for their items 10, 20, 30? If I understand correctly if this is not done, then some items will have displayOrder=null which means we have to think about it during sorting.
|
I've also noticed if I use sample from ticket, reorder xml in this way: given (no display order), email (30), family (20) then order on page is given, family, email...Wasn't it described in schema as null order goes last? could it be because of my previous comment? |
2 participants
No description provided.