feat: Speaker Api Automatic id assign & Added Pool logic & more log less throw#762
Open
MS-crew wants to merge 16 commits intoExMod-Team:devfrom
Open
feat: Speaker Api Automatic id assign & Added Pool logic & more log less throw#762MS-crew wants to merge 16 commits intoExMod-Team:devfrom
MS-crew wants to merge 16 commits intoExMod-Team:devfrom
Conversation
Someone-193
reviewed
Mar 1, 2026
|
if we're gonna test error handling for the speaker api, could you at least check each type of error and make sure it doesnt spam the log if an issue happens then let us know you've tested all the errors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Read Tittle
What is the current behavior? (You can also link to an open issue here)
Tittle
What is the new behavior? (if this is a feature change)
Read
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other