Skip to content

feat: Speaker Api Automatic id assign & Added Pool logic & more log less throw#762

Open
MS-crew wants to merge 16 commits intoExMod-Team:devfrom
MS-crew:SpeakerApiRereborn
Open

feat: Speaker Api Automatic id assign & Added Pool logic & more log less throw#762
MS-crew wants to merge 16 commits intoExMod-Team:devfrom
MS-crew:SpeakerApiRereborn

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented Feb 27, 2026

Description

Describe the changes
Read Tittle

What is the current behavior? (You can also link to an open issue here)
Tittle

What is the new behavior? (if this is a feature change)
Read

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Feb 27, 2026
@MS-crew MS-crew changed the title feat: Automatic id assign / more log & less throw feat: Speaker Api Automatic id assign / more log & less throw Feb 27, 2026
@Someone-193
Copy link

if we're gonna test error handling for the speaker api, could you at least check each type of error and make sure it doesnt spam the log if an issue happens then let us know you've tested all the errors?

@MS-crew MS-crew changed the title feat: Speaker Api Automatic id assign / more log & less throw feat: Speaker Api Automatic id assign & Added PlayOneShot method & more log less throw Mar 1, 2026
@MS-crew MS-crew changed the title feat: Speaker Api Automatic id assign & Added PlayOneShot method & more log less throw feat: Speaker Api Automatic id assign & Added Pool logic & more log less throw Mar 1, 2026
@github-actions github-actions bot added the Events label Mar 1, 2026
@MS-crew MS-crew requested a review from Someone-193 March 2, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants