feat: NetworkConnection extensions#821
Open
michcio15 wants to merge 2 commits into
Open
Conversation
michcio15
changed the title
VALERA771
reviewed
May 10, 2026
VALERA771
left a comment
VALERA771
left a comment
There was a problem hiding this comment.
I don't really think that this is necessary. I can agree on people using LabAPI player class in plugin but we have an implicit operator to cast it to EXILED version of player (and tbh I don't really see a reason to use LabAPI and EXILED at the same time)
Author
|
For me there is no need to keep it tied only to the Player class since its not even used in it and it uses the connection. Also it could make it easier to write transpilers with faking network |
louis1706
requested changes
May 10, 2026
Comment on lines
-16
to
59
| using System.Text; | ||
|
|
||
| using AdminToys; | ||
|
|
||
| using AudioPooling; | ||
|
|
||
| using Cassie; | ||
|
|
||
| using CustomPlayerEffects; | ||
|
|
||
| using Exiled.API.Enums; | ||
| using Exiled.API.Features.Items; | ||
| using Exiled.API.Features.Items.Keycards; | ||
| using Exiled.API.Features.Pickups.Keycards; | ||
|
|
||
| using Features; | ||
| using Features.Pools; | ||
|
|
||
| using InventorySystem; | ||
| using InventorySystem.Items; | ||
| using InventorySystem.Items.Autosync; | ||
| using InventorySystem.Items.Firearms; | ||
| using InventorySystem.Items.Firearms.Modules; | ||
| using InventorySystem.Items.Keycards; | ||
|
|
||
| using MEC; | ||
|
|
||
| using Mirror; | ||
|
|
||
| using PlayerRoles; | ||
| using PlayerRoles.Blood; | ||
| using PlayerRoles.FirstPersonControl; | ||
| using PlayerRoles.PlayableScps.Scp049.Zombies; | ||
| using PlayerRoles.PlayableScps.Scp1507; | ||
| using PlayerRoles.Spectating; | ||
| using PlayerRoles.Voice; | ||
|
|
||
| using RelativePositioning; | ||
|
|
||
| using Respawning; | ||
|
|
||
| using UnityEngine; | ||
|
|
||
| using Utils.Networking; |
There was a problem hiding this comment.
Remove this change please and all other spacing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adds NetworkConnection as target of mirro extensions
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Now there are more extension that use NetworkConnection
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
This is added so devs using LabAPI player (in events for example) / more base game stuff can still use the extensions since they dont require most of the time exileds player just the connection.
Still a WiP however feedback is welome
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other