chore(63871): update @onfido/react-native and onfido-sdk-ui #69591

Kureev · 2025-09-01T09:36:03Z

Explanation of Change

Update @onfido/react-native and onfido-sdk-ui are built with 16Kb memory pages (align=0x4000), which is required for Android 15+ compatibility.
armeabi-v7a libs remain at 4 KB alignment, which is expected since Android 15+ devices no longer run 32-bit code.

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13661

Fixed Issues

$ #63871
PROPOSAL: #63871

Tests

Ran llvm-readelf -l on all arm64-v8a .so files and confirmed p_align=0x4000 (16 KB) for each.
Verified that the APK/AAB passes zipalign -c -P 16.
Alternatively, run scripts/check-16kb-android.sh with the path to the APK to check all alignments in the bundle.
Installed the app on an Android 15 emulator and verified that it launches and runs without native crashes.
Confirmed no regressions in core flows (sign-in, navigation, chat, attachments).

Verify that no errors appear in the JS console

Offline tests

Tested launching the app with airplane mode enabled → verified it falls back gracefully (no native crashes).
Spotty connection simulation → verified chat messages queue and sync after reconnection.

QA Steps

Same as tests:

Confirm that the app installs and runs on Android 15 devices without native crashes.
Confirm normal behavior in core flows (login, messaging, navigation).
Verify that no errors appear in the JS console.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-01T09:36:09Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-09-01T09:36:11Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Kureev · 2025-09-01T10:27:26Z

There are tests failing but these come from main

Kureev · 2025-09-02T09:25:43Z

Now everything is green. Any chance you can take a look @jayeshmangwani?

jayeshmangwani · 2025-09-03T09:34:09Z

@Kureev Please include the Podfile.lock changes here, as running pod install is causing this issue locally for me.

jayeshmangwani · 2025-09-03T09:35:17Z

I ran pod update Onfido locally, and that resulted in a few changes to the Podfile.lock file.

jayeshmangwani · 2025-09-03T12:06:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mp4

Android: mWeb Chrome

mweb-chrome.mp4

iOS: HybridApp

iOS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani · 2025-09-03T12:12:00Z

@Kureev Onfido is throwing an error on Android, and the console shows this message: NFC related dependencies are missing, please follow the integration documentation

Android-bug.mp4

Kureev · 2025-09-03T14:11:18Z

Gotcha, looking into this

jayeshmangwani · 2025-09-05T05:54:57Z

@Kureev Please ping me once the Android issue is fixed and the PR is ready for review again.

Kureev · 2025-09-09T11:16:53Z

I just managed to connect a bank account through the wallet. Not sure if it was the same flow as you tried, @jayeshmangwani, but if it's not, could you please tell me how to follow your steps more precisely?

jayeshmangwani · 2025-09-09T12:02:08Z

@Kureev Yes sure adding the details below

Steps Followed:

From Troubleshoot menu, ensure that "Use Staging Server" is enabled.
Go to any Workspace -> Workflows -> click Add bank account.
Select "Log into your bank".
A Sandbox Plaid popup opens.
On the Plaid sign-in screen, use:
- Username: user_good
- Password: pass_good
Select the Plaid savings account ending in 1111.
Finish the Plaid flow.
Use the following values on Bank info page:
- Routing Number: 011401533
- Account Number: 1111222233331111
Add the other required details (or use the same values as shown in the attached video).
You will reach the Verify identity page.

I’ve added a video below showing how I added a bank account to reach the Verify identity page. You can use the same values from the video in the required fields if needed.

onfido.mov

Kureev · 2025-09-16T12:05:19Z

@jayeshmangwani fixed the issue with the NFC, but it doesn't go further than the selfie as I don't have a real device, so can't really test it further

jayeshmangwani · 2025-09-16T20:29:38Z

@Kureev Are we sure it’s safe to delete patches/@onfido+react-native-sdk+10.6.0.patch? We’ve added some changes to the patch in this PR #45289, and since the mentioned upstream PR onfido/react-native-sdk#115 hasn’t been merged yet, I just want to double-check.

jayeshmangwani · 2025-09-16T20:31:19Z

I think the committed Mobile-Expensify Submodule changes may have been added by mistake.

jayeshmangwani · 2025-09-16T21:06:23Z

src/components/Onfido/index.native.tsx

            sdkToken,
            theme: OnfidoTheme.AUTOMATIC,
+            // eslint-disable-next-line
+            nfcOption: OnfidoNFCOptions.DISABLED,


Curious — why are we disabling ESLint here? I don’t see any lint warnings locally for nfcOption: OnfidoNFCOptions.DISABLED.

I do have two errors from eslint there

jayeshmangwani · 2025-09-16T21:07:58Z

fixed the issue with the NFC, but it doesn't go further than the selfie as I don't have a real device, so can't really test it further

Latest changes seem to be working, I can test the selfie, video, and audio recording parts on Onfido now.

Kureev · 2025-09-17T08:58:03Z

I think the committed Mobile-Expensify Submodule changes may have been added by mistake.
Nope, the OldDot has old Onfido in the iOS/Podfile.lock which breaks npm run pod-install due to incompatible versions.

I can compose a smaller PR that will include only Onfido-related changes if you'd like.

jayeshmangwani · 2025-09-17T09:23:58Z

I can compose a smaller PR that will include only Onfido-related changes if you'd like.

I was under the impression that we’d need to add the Mobile-Expensify changes in the Mobile-Expensify repo rather than this one. That said, the PR looks good overall and tests well.
We do have some conflicts, but we can resolve those before merging once Rory comes online, probably better to handle them then so we don’t run into conflicts again.

jayeshmangwani

LGTM 🚀

OSBotify · 2025-09-18T16:52:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

war-in · 2025-09-19T12:13:09Z

@Kureev we also need an OD PR because hybrid iOS builds are failing now due to a lack of changes in the Podfile.lock
Could you please submit the PR? 🙏

mateuuszzzzz · 2025-09-19T16:19:16Z

We updated lock here: https://github.com/Expensify/Mobile-Expensify/pull/13708

OSBotify · 2025-09-19T22:51:36Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.16-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-09-23T19:33:49Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Kureev requested a review from a team as a code owner September 1, 2025 09:36

melvin-bot bot assigned Kureev Sep 1, 2025

melvin-bot bot requested review from jayeshmangwani and removed request for a team September 1, 2025 09:36

Kureev force-pushed the kureev/63871-part1 branch 3 times, most recently from 1cd7c63 to c032ddf Compare September 1, 2025 21:05

Kureev mentioned this pull request Sep 2, 2025

[HOLD] Enable 16KB memory page size on Android #69161

Closed

51 tasks

roryabraham self-requested a review September 3, 2025 05:12

Kureev force-pushed the kureev/63871-part1 branch 2 times, most recently from 853f4ac to 10f0d31 Compare September 4, 2025 08:39

roryabraham mentioned this pull request Sep 5, 2025

[HOLD https://github.com/callstackincubator/android/issues/15] [$250] Enable 16KB memory page size on Android #63871

Open

Kureev force-pushed the kureev/63871-part1 branch from 10f0d31 to c092aec Compare September 9, 2025 11:15

Kureev force-pushed the kureev/63871-part1 branch from c092aec to 8f0e9cc Compare September 11, 2025 11:21

Kureev added 4 commits September 11, 2025 14:50

chore(63871): update @onfido/react-native and onfido-sdk-ui

125f027

chore(63871): update onfido (again) and generate Podfile.lock

74fb12b

fix(63871): rebase and re-install pods

6b566a5

fix(63871): move submodule ref to the correct commit

c3e52e1

Kureev added 5 commits September 15, 2025 23:13

Merge branch 'main' into kureev/63871-part1

abf7ee5

Merge branch 'main' into kureev/63871-part1

2d1d193

chore(63871): update submodule

e56f32e

Merge branch 'main' into kureev/63871-part1

0cd124e

fix(63871): disable nfc for the latest onfido version

4f89870

Kureev added 3 commits September 16, 2025 17:59

Merge branch 'main' into kureev/63871-part1

f32a046

chore(63871): move submodule head

71d5238

Merge branch 'main' into kureev/63871-part1

1d28207

jayeshmangwani reviewed Sep 16, 2025

View reviewed changes

jayeshmangwani approved these changes Sep 17, 2025

View reviewed changes

Kureev added 6 commits September 17, 2025 12:48

Merge branch 'main' into kureev/63871-part1

c958f64

chore(63871): update submodule head

a54a5d3

Merge branch 'main' into kureev/63871-part1

2529dcf

Merge branch 'main' into kureev/63871-part1

0283b1c

chore(63871): move submodule head

8513005

chore(63871): update submodule head

d6bd598

roryabraham approved these changes Sep 18, 2025

View reviewed changes

roryabraham merged commit fa7da0d into Expensify:main Sep 18, 2025
28 checks passed

OSBotify mentioned this pull request Sep 19, 2025

Deploy Checklist: New Expensify 2025-09-19 #70900

Closed

chore(63871): update @onfido/react-native and onfido-sdk-ui #69591

chore(63871): update @onfido/react-native and onfido-sdk-ui #69591

Uh oh!

Conversation

Kureev commented Sep 1, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 1, 2025

Uh oh!

github-actions bot commented Sep 1, 2025

Uh oh!

Kureev commented Sep 1, 2025

Uh oh!

Kureev commented Sep 2, 2025

Uh oh!

jayeshmangwani commented Sep 3, 2025

Uh oh!

jayeshmangwani commented Sep 3, 2025

Uh oh!

jayeshmangwani commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani commented Sep 3, 2025

Uh oh!

Kureev commented Sep 3, 2025

Uh oh!

jayeshmangwani commented Sep 5, 2025

Uh oh!

Kureev commented Sep 9, 2025

Uh oh!

jayeshmangwani commented Sep 9, 2025

Uh oh!

Kureev commented Sep 16, 2025

Uh oh!

jayeshmangwani commented Sep 16, 2025

Uh oh!

jayeshmangwani commented Sep 16, 2025

Uh oh!

jayeshmangwani Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

Kureev Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Sep 16, 2025

Uh oh!

Kureev commented Sep 17, 2025

Uh oh!

jayeshmangwani commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 18, 2025

Uh oh!

war-in commented Sep 19, 2025

Uh oh!

mateuuszzzzz commented Sep 19, 2025

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

OSBotify commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

jayeshmangwani commented Sep 3, 2025 •

edited

Loading

jayeshmangwani commented Sep 17, 2025 •

edited

Loading