-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Call get duplicate transaction details on duplicates review page #78476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Call get duplicate transaction details on duplicates review page #78476
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…DuplicateTransactionDetails-on-duplicates-review-page
…DuplicateTransactionDetails-on-duplicates-review-page
|
@mollfpr What's holding this in draft? Given that the related backend PRs have already been deployed. |
|
Sorry, I’ve been focusing on other critical issues. The last test I did, it’s still left a bug. I’ll try to finish it today/tomorrow 🙏 |
|
@mollfpr No worries at all. I just wasn't sure whether it was ready for review and just being held because of the related backend issues. |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment was marked as duplicate.
This comment was marked as duplicate.
…DuplicateTransactionDetails-on-duplicates-review-page
Explanation of Change
We have create new API
GetDuplicateTransactionDetailsto return the transaction and IOU action related to duplicates transaction. When the review duplicate page open, it will call the API and correctly show the duplicates transaction even after clear cache.Fixed Issues
$ #74525
PROPOSAL:
Tests
Precondition:
Offline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.Jan.8.2026.mp4