Fix report appearing unread after returning online when messages sent offline

[MelvinBot]

Explanation of Change

When messages are sent while offline and then the user reads the report (also offline), readNewestAction captures lastReadTime at that moment. On reconnect, the SequentialQueue replays requests FIFO: the AddComment requests are processed first, and the server assigns them new server-side timestamps that are later than the stale lastReadTime. When ReadNewestAction is then processed with the stale timestamp, lastReadTime < lastVisibleActionCreated, causing the report to incorrectly appear as unread in the LHN.

This fix adds bounded reconciliation in SequentialQueue: during queue flush, it tracks which report IDs had offline outgoing message commands (AddComment, AddAttachment, AddTextAndAttachment) successfully processed. When an offline ReadNewestAction is about to be sent for one of those reports, its lastReadTime is refreshed to the current time so it covers the server-assigned message timestamps. Reports without offline messages are unaffected, preventing auto-reading messages from other users.

Fixed Issues

$ #79837
PROPOSAL: #79837 (comment)

Tests

1. Create a report with another user and exchange a few messages
2. Switch to offline mode
3. Send several messages in the report
4. Mark the last message as unread via long press > "Mark as unread"
5. Navigate to Inbox, then reopen the same report so it becomes read
6. Open a different report
7. Switch back to online
8. Verify the original report is displayed as read (not bold) in the LHN

• Verify that no errors appear in the JS console

Offline tests

1. Repeat the test steps above (the entire test is an offline scenario)
2. Additionally test the regression scenario: go offline without sending messages, navigate between reports, have another user send a message, go online → verify the new message shows as unread

QA Steps

1. Create a report with multiple expense items
2. Open the report
3. Switch the app to offline mode
4. Send several messages within the report
5. Mark the last message as unread
6. Navigate to the Inbox, then reopen the same report so the message becomes marked as read
7. Open any other report
8. Switch the app back online
9. Verify the report is displayed as read in the LHN

Regression check:

1. Open chat with another user (A opens chat with B)
2. Go offline
3. Go to another report
4. Go back to chat with B
5. Go to another report
6. B sends a new message to A
7. A goes online
8. Verify B's new message is displayed as unread

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A - logic-only change in SequentialQueue, no UI changes

Android: mWeb Chrome

N/A - logic-only change in SequentialQueue, no UI changes

iOS: Native

N/A - logic-only change in SequentialQueue, no UI changes

iOS: mWeb Safari

N/A - logic-only change in SequentialQueue, no UI changes

MacOS: Chrome / Safari

N/A - logic-only change in SequentialQueue, no UI changes

[MelvinBot]

Fixed the failing Prettier check — the multi-line if condition in SequentialQueue.ts (line ~248) needed to be collapsed to a single line per Prettier's formatting rules.

The test failures (jobs 1, 5, 6, 7, 8) are unrelated to this PR. They all fail with TypeError: (0 , _memoize.default) is not a function across various test files (ComposerTest.tsx, EmojiUtilsTest.ts, PureReportActionItemTest.tsx, etc.) — none of which are touched by this PR. This appears to be a pre-existing/transient CI issue. The Jest tests on main were passing in the most recent run.

[MelvinBot]

Fixed the failing Jest tests. The root cause was a circular dependency introduced by the top-level import NetworkConnection from '@libs/NetworkConnection' in SequentialQueue.ts:

SequentialQueue → NetworkConnection → DateUtils → Localize/index → memoize → memoize/stats → Log → Network/index → Network/MainQueue → Request → SequentialQueue (cycle!)

This caused memoize to be undefined when Localize/index.ts tried to call it at module load time, resulting in TypeError: (0 , _memoize.default) is not a function.

Fix: Replaced the top-level import with a lazy require() inside the process() function body. This defers the module loading to runtime when all modules have finished initializing, breaking the circular dependency at load time.

[MelvinBot]

The original test failure (circular dependency causing TypeError: (0, _memoize.default) is not a function) has been fixed in the latest commit by using a lazy require() for NetworkConnection in SequentialQueue.ts.

The remaining failures in the latest run are unrelated flaky tests:

1. tests/ui/SearchPageTest.tsx — fails to find search-autocomplete-text-input element (UI timing issue)
2. tests/ui/SessionTest.tsx — test timeout (120s exceeded) and "Can't access .root on unmounted test renderer"

Neither test is related to the SequentialQueue.ts changes in this PR. Job 8 (which contains these tests) passes on main. Please re-run the failed jobs to confirm.

[MelvinBot]

Fixed the failing checks. The test (job 8) failure was caused by the dynamic require('@libs/NetworkConnection') inside process().

Root cause: The require() call triggered NetworkConnection's module-level side effects (NetInfo subscriptions, Onyx connections, etc.) when loaded mid-test. This destabilized the test environment, causing random test failures in different suites each run (SearchPageTest, SessionTest, GoBackTests, TableTest, etc. — different tests failed on each of the 3 CI runs).

Fix: Replaced the dynamic require() with inline logic:

• Read networkTimeSkew from the existing ONYXKEYS.NETWORK Onyx subscription already in SequentialQueue.ts
• Inline the simple DB-time formatting (new Date().toISOString().replace('T', ' ').replace('Z', '')) which is equivalent to DateUtils.getDBTime()

This avoids the circular dependency without loading the heavy NetworkConnection module at runtime.

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/Network/SequentialQueue.ts	82.98% <62.50%> (-1.21%)	⬇️
... and 26 files with indirect coverage changes