[No QA] Remove unused eslint-disable directives#83798
Draft
roryabraham wants to merge 1 commit intomainfrom
Draft
[No QA] Remove unused eslint-disable directives#83798roryabraham wants to merge 1 commit intomainfrom
roryabraham wants to merge 1 commit intomainfrom
Conversation
Upgrade eslint-config-expensify to a version that sets reportUnusedDisableDirectives: 'error', remove the local override that disabled this check, and auto-fix all 1100+ stale directives across the codebase. Made-with: Cursor
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Upgrades
eslint-config-expensifyto a version that includesreportUnusedDisableDirectives: 'error'in the base config, removes the local override ineslint.config.mjsthat previously disabled this check, and auto-fixes all ~1100 staleeslint-disabledirectives across the codebase.Depends on Expensify/eslint-config-expensify#180
Fixed Issues
N/A - tooling improvement
Tests
npx eslint src/ tests/ .github/ scripts/and verify noUnused eslint-disable directiveerrors appearOffline tests
N/A - no runtime behavior change
QA Steps
N/A - no runtime behavior change. This is a lint-only change.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)Screenshots/Videos
N/A - no UI changes
Made with Cursor