Skip to content

[Android] Keep video controls visible while seeking#83800

Draft
chassidysandraik-hash wants to merge 1 commit intoExpensify:mainfrom
chassidysandraik-hash:fix/82026-android-video-seek
Draft

[Android] Keep video controls visible while seeking#83800
chassidysandraik-hash wants to merge 1 commit intoExpensify:mainfrom
chassidysandraik-hash:fix/82026-android-video-seek

Conversation

@chassidysandraik-hash
Copy link

@chassidysandraik-hash chassidysandraik-hash commented Feb 28, 2026

Goal

Fix Android DM video seeking: keep controls visible while dragging the progress bar.

Problem

On Android, dragging the video progress bar causes the controls to fade out/disappear mid-gesture, preventing seeking.

Solution

  • Track an isSeeking state and short-circuit auto-hide while the progress bar is being dragged.
  • Cancel any in-flight opacity animation and force controls visible on seek start.
  • Resume the debounced auto-hide after seek ends (only when appropriate: playing, touchscreen, popover not visible).

Testing

  • Android: Open a DM with a video attachment, play the video, drag the progress bar forward/backward and confirm the controls remain visible and the seek completes.
  • iOS/Web: No behavior change expected.

$ #82026

PR Author Checklist

  • I have read and followed the guidelines in the Contributing document.
  • I have performed a self-review of my code.
  • I have tested my changes and confirmed they work as expected.

Screenshots/Videos

N/A

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@melvin-bot melvin-bot bot requested review from mollfpr and removed request for a team February 28, 2026 23:54
@melvin-bot
Copy link

melvin-bot bot commented Feb 28, 2026

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from heyjennahay and removed request for a team February 28, 2026 23:54
@chassidysandraik-hash chassidysandraik-hash marked this pull request as draft March 1, 2026 00:08
@chassidysandraik-hash
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Mar 1, 2026
@chassidysandraik-hash
Copy link
Author

recheck

2 similar comments
@chassidysandraik-hash
Copy link
Author

recheck

@chassidysandraik-hash
Copy link
Author

recheck

@chassidysandraik-hash
Copy link
Author

The CLA check is now passing after signing — thanks. \n\nThe action is failing with a inside , even though the PR body includes an Author Checklist section with checked items.\n\nCould someone please advise what exact checklist header/format the action expects, or if this is a known workflow regression? Happy to adjust the PR description accordingly.

@chassidysandraik-hash
Copy link
Author

The CLA check is now passing after signing — thanks.

The checklist action is failing with a TypeError: Cannot read properties of undefined (reading 'split') inside .github/actions/javascript/authorChecklist, even though the PR body includes an Author Checklist section with checked items.

Could someone please advise what exact checklist header/format the action expects, or if this is a known workflow regression? Happy to adjust the PR description accordingly.

@chassidysandraik-hash
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant