refactor: handle delay submissions message help site URL with explain feature#83802
refactor: handle delay submissions message help site URL with explain feature#83802samranahm wants to merge 2 commits intoExpensify:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad34bcbf4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR implements the handling of the "delay submissions" message for reports submitted via harvesting (delayed submission workflow). When Concierge sends an automated submit message that also has AI reasoning attached, it now shows a restructured UI with the text "submitted via [delay submissions link]. [Explain] ✨" instead of the previous HTML-rendered automaticallySubmitted string.
Changes:
- New
wasSubmittedViaHarvestingprop added toReportActionItemMessageWithExplainto conditionally render a custom "submitted via delay submissions" layout with a clickable link and the Explain feature. - New
submittedViaanddelaySubmissionstranslation keys added across all 10 supported languages. PureReportActionItem.tsxnow passeswasSubmittedViaHarvestingto theReportActionItemMessageWithExplaincomponent when the submitted action was via harvesting.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
ReportActionItemMessageWithExplain.tsx |
Adds wasSubmittedViaHarvesting prop and the new "submitted via delay submissions + Explain" rendering branch |
PureReportActionItem.tsx |
Passes wasSubmittedViaHarvesting to the component when the SUBMITTED/SUBMITTED_AND_CLOSED action used harvesting |
en.ts |
Adds submittedVia and delaySubmissions translation keys |
de.ts, es.ts, fr.ts, it.ts, nl.ts, pl.ts, pt-BR.ts, zh-hans.ts |
Same two keys added in each respective language |
ja.ts |
Same keys added, but with incorrect word order (see comments) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Explanation of Change
Fixed Issues
$ #82171
PROPOSAL:
Tests
Offline tests
QA Steps
Same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari