Skip to content

chore: cleanup#119

Merged
JoE11-y merged 1 commit intomainfrom
stellar-integrations
Apr 16, 2026
Merged

chore: cleanup#119
JoE11-y merged 1 commit intomainfrom
stellar-integrations

Conversation

@JoE11-y
Copy link
Copy Markdown
Contributor

@JoE11-y JoE11-y commented Apr 16, 2026

Summary by CodeRabbit

  • Documentation

    • Updated EVM contract documentation with protocol/interface changes.
  • Chores

    • Removed legacy deployment automation scripts and related configuration files.
    • Improved line-ending handling for shell and Docker build scripts.
    • Updated build script references.

@JoE11-y JoE11-y merged commit cae87b6 into main Apr 16, 2026
3 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 64bd472d-9b3e-4eb7-862e-0a110df1792f

📥 Commits

Reviewing files that changed from the base of the PR and between 32759c6 and 0a9a475.

📒 Files selected for processing (15)
  • .gitattributes
  • .gitignore
  • contracts/evm/README.md
  • contracts/evm/js-scripts/deploy/.gitignore
  • contracts/evm/js-scripts/deploy/README.md
  • contracts/evm/js-scripts/deploy/config.template.json
  • contracts/evm/js-scripts/deploy/core/deployer.ts
  • contracts/evm/js-scripts/deploy/core/setup.ts
  • contracts/evm/js-scripts/deploy/core/types.ts
  • contracts/evm/js-scripts/deploy/core/utils.ts
  • contracts/evm/js-scripts/deploy/deploy.ts
  • contracts/evm/js-scripts/deploy/scenarios/sepolia-hedera.ts
  • contracts/evm/js-scripts/deploy/scenarios/standard.ts
  • contracts/evm/package.json
  • scripts/docker-local/Dockerfile.deployer

📝 Walkthrough

Walkthrough

The pull request removes the entire EVM deployment scripting system (all deployment, setup, and scenario orchestration modules) and updates documentation to reflect protocol changes from 20-byte addresses to 32-byte bytes32 fields. Configuration updates include adding line-ending normalization and updating package.json scripts.

Changes

Cohort / File(s) Summary
Configuration & Line Endings
.gitattributes, .gitignore
Added LF line-ending enforcement for shell scripts and Dockerfiles; added dump/ to ignore patterns.
Documentation Update
contracts/evm/README.md
Updated protocol documentation to reflect address→bytes32 type changes, removed deployed contracts and supported routes sections, updated Order struct to OrderParams, removed deployment guidance sections.
Deployment System Removal
contracts/evm/js-scripts/deploy/...
Removed entire deployment infrastructure: CLI entrypoint (deploy.ts), core modules (deployer.ts, setup.ts, types.ts, utils.ts), scenario implementations (standard.ts, sepolia-hedera.ts), configuration template (config.template.json), documentation (README.md), and gitignore file.
Package & Dockerfile Updates
contracts/evm/package.json, scripts/docker-local/Dockerfile.deployer
Removed deploy and deploy:help npm scripts; updated deployer image to normalize CRLF line endings in entrypoint script.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • Ugo-X

Poem

🐰 The deployer hops away with grace,
Scripts fade without a trace,
Bytes32 now lead the way,
Line endings fixed to save the day,
A cleaner path for protocols to play! 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stellar-integrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant