Skip to content

[fix]: Prevent file resource upload on dry run#1049

Merged
MiquelAdell merged 2 commits intodevelopmentfrom
fix/prevent-file-resource-upload-on-dry-run
Mar 3, 2026
Merged

[fix]: Prevent file resource upload on dry run#1049
MiquelAdell merged 2 commits intodevelopmentfrom
fix/prevent-file-resource-upload-on-dry-run

Conversation

@deeonwuli
Copy link
Copy Markdown
Contributor

@deeonwuli deeonwuli commented Feb 25, 2026

📌 References

📝 Implementation

This PR updates the sync logic to prevent uploading FileResource data elements when a dry run is requested. When

  • dryRun is true in dataParams for aggregated data synchronization or
  • importMode is "VALIDATE" for event synchronization
    the code now skips the manageDataElementWithFileType step that fetches and uploads file resources and uses the original payload directly.

📹 Screenshots/Screen capture

📑 Others

#869c32tua

@ifoche
Copy link
Copy Markdown
Member

ifoche commented Feb 25, 2026

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Feb 25, 2026

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
Build Folder
./**/*
2.78MB (+13B 0%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@deeonwuli deeonwuli marked this pull request as ready for review March 2, 2026 10:25
Copy link
Copy Markdown
Contributor

@gqcorneby gqcorneby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[code only] Changes look good 👍

@MiquelAdell MiquelAdell merged commit dd314cb into development Mar 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants