Skip to content

Scf convergence migration#151

Draft
JFRudzinski wants to merge 9 commits intoschema_update_convergence_targetsfrom
scf-convergence-migration
Draft

Scf convergence migration#151
JFRudzinski wants to merge 9 commits intoschema_update_convergence_targetsfrom
scf-convergence-migration

Conversation

@JFRudzinski
Copy link
Collaborator

@JFRudzinski JFRudzinski commented Feb 17, 2026

Implemented SCF convergence migration across all target parsers (abinit, ams, crystal, exciting, fhiaims, gpaw, quantumespresso, vasp) to the new workflow + scf_steps model.

High-level changes:

  • Ported parser-specific SCF iteration signals into outputs.scf_steps (energy deltas, energies, durations, and code-specific SCF metadata where available).
  • Populated new workflow convergence targets in workflow2 (SinglePoint, GeometryOptimization, and MD where relevant), including SCF and geometry thresholds.
  • Updated parser schema mappings to expose the new scf_steps fields and avoid duplicated/legacy convergence storage.
  • Added/extended parser tests with explicit assertions on:
    • workflow type/method and convergence target thresholds/types
    • SCF-step quantity presence, lengths, and representative values
  • Updated migration documentation (SCF_CONVERGENCE_MIGRATION.md) with per-parser status, approach, caveats, and test outcomes.

Net result:

  • Convergence information now follows one consistent structure across parsers, aligned with the refactored schema and NOMAD unit handling semantics.

depends on FAIRmat-NFDI/nomad-simulations#260

@JFRudzinski JFRudzinski changed the base branch from develop to schema_update_convergence_targets February 17, 2026 22:14
@JFRudzinski
Copy link
Collaborator Author

Here are the implementation notes:

SCF_CONVERGENCE_MIGRATION.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant