Skip to content

Fix: Renaming a judging room/table preserves list order #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: Renaming a judging room/table preserves list order #2112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15dd754
Initial plan
Copilot May 4, 2026
41aa78a
Fix: preserve asset order when renaming judging room or robot game table
Copilot May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/admin/src/app/[locale]/(dashboard)/events/[slug]/venue/components/asset-manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ export const AssetManager = <T extends AssetType>({ division, assetType }: Asset
const {
data: assets = [] as T[],
error,
isLoading
isLoading,
mutate: updateAssets
} = useSWR<T[]>(
division ? `/admin/events/${division.eventId}/divisions/${division.id}/${assetType}` : null,
{
Expand Down Expand Up @@ -123,7 +124,11 @@ export const AssetManager = <T extends AssetType>({ division, assetType }: Asset
return rest;
});
showSuccess();
mutate(`/admin/events/${division.eventId}/divisions/${division.id}/${assetType}`);
// Update the asset name in-place to preserve list order
updateAssets(
currentAssets => currentAssets?.map(a => (a.id === asset.id ? { ...a, name } : a)) as T[],
{ revalidate: false }
);
} else {
setErrors({ [asset.id]: t('messages.save-error') });
}
Expand Down
Loading