Conversation
Owner
|
@Macacoazul01 sorry, I missed this! Thanks for pinginr me again, will look into it today or tomorrow. |
|
@FaFre are there any other branches or PR in the original one that are worth implementing? |
Owner
|
Thanks for the PR! @Macacoazul01 everything looks good to me. I haven't seen anything that was useful to myself. Please feel free to open another PR in case you find something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for updating and maintaining the
auto_size_textpackage.I noticed that you did not implement the grouping functionality of the orginal library.
Here is a PR that implements the
AutoSizeGroup.In addition, I needed to change the library structure because the
AutoSizeGroupneeded access to the private_AutoSizeBuilderState. Now everything is contained in a single library usingpartandpart of. However, I made sure that the public API is clean by changing the visibliity of the non-public methods and classes.Best,
Halil Göcer